From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752751AbbKKNT3 (ORCPT ); Wed, 11 Nov 2015 08:19:29 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:6012 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752283AbbKKNT1 (ORCPT ); Wed, 11 Nov 2015 08:19:27 -0500 X-IronPort-AV: E=Sophos;i="5.20,275,1444687200"; d="scan'208";a="153474741" Date: Wed, 11 Nov 2015 13:19:23 +0000 (GMT) From: Julia Lawall X-X-Sender: jll@hadrien To: Dave Penkler cc: gregkh@linuxfoundation.org, peter.chen@freescale.com, teuniz@gmail.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dpenkler@gmail.com Subject: [PATCH] fix compare_const_fl.cocci warnings Message-ID: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move constants to the right of binary operators. Semantic patch information: Depends on personal taste in some cases. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci CC: Dave Penkler Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- This is what Coccinelle generates. But it would really be more normal in the form !(x&y). usbtmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/class/usbtmc.c +++ b/drivers/usb/class/usbtmc.c @@ -494,7 +494,7 @@ static int usbtmc488_ioctl_simple(struct dev = &data->intf->dev; - if (0 == (data->usb488_caps & USBTMC488_CAPABILITY_SIMPLE)) + if ((data->usb488_caps & USBTMC488_CAPABILITY_SIMPLE) == 0) return -EINVAL; buffer = kmalloc(8, GFP_KERNEL);