From: Julia Lawall <julia.lawall@lip6.fr>
To: Saurabh Sengar <saurabh.truth@gmail.com>
Cc: mans@mansr.com, Peter.Chen@freescale.com,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Saurabh Sengar <saurabh.truth@gmail.com>,
kbuild-all@01.org
Subject: Re: [PATCH v2] usb: chipidea: removing of_find_property
Date: Tue, 17 Nov 2015 13:58:03 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.10.1511171357090.2455@hadrien> (raw)
In-Reply-To: <201511172007.DmGhbpj1%fengguang.wu@intel.com>
Please check. The code, with the blank line on line 692, looks strange.
julia
On Tue, 17 Nov 2015, kbuild test robot wrote:
> CC: kbuild-all@01.org
> In-Reply-To: <1447760410-3426-1-git-send-email-saurabh.truth@gmail.com>
> TO: Saurabh Sengar <saurabh.truth@gmail.com>
> CC: mans@mansr.com, Peter.Chen@freescale.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Saurabh Sengar <saurabh.truth@gmail.com>
> CC: Saurabh Sengar <saurabh.truth@gmail.com>
>
> Hi Saurabh,
>
> [auto build test WARNING on peter.chen-usb/ci-for-usb-next]
> [also build test WARNING on v4.4-rc1 next-20151117]
>
> url: https://github.com/0day-ci/linux/commits/Saurabh-Sengar/usb-chipidea-removing-of_find_property/20151117-194333
> base: https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb ci-for-usb-next
> :::::: branch date: 68 minutes ago
> :::::: commit date: 68 minutes ago
>
> >> drivers/usb/chipidea/core.c:693:1-27: code aligned with following code on line 695
>
> git remote add linux-review https://github.com/0day-ci/linux
> git remote update linux-review
> git checkout 4375ac1189e900bbde912d31ec3bb66572c0784a
> vim +693 drivers/usb/chipidea/core.c
>
> 63863b98 Heikki Krogerus 2015-09-21 687 if (usb_get_maximum_speed(dev) == USB_SPEED_FULL)
> 4f6743d5 Michael Grzeschik 2014-02-19 688 platdata->flags |= CI_HDRC_FORCE_FULLSPEED;
> 4f6743d5 Michael Grzeschik 2014-02-19 689
> 4375ac11 Saurabh Sengar 2015-11-17 690 if (!of_property_read_u32(dev->of_node, "phy-clkgate-delay-us",
> 4375ac11 Saurabh Sengar 2015-11-17 691 &platdata->phy_clkgate_delay_us))
> 1fbf4628 Fabio Estevam 2015-09-08 692
> df96ed8d Peter Chen 2014-09-22 @693 platdata->itc_setting = 1;
> 4375ac11 Saurabh Sengar 2015-11-17 694
> df96ed8d Peter Chen 2014-09-22 @695 ret = of_property_read_u32(dev->of_node, "itc-setting",
> df96ed8d Peter Chen 2014-09-22 696 &platdata->itc_setting);
> 4375ac11 Saurabh Sengar 2015-11-17 697 if (ret && ret != -EINVAL) {
> 4375ac11 Saurabh Sengar 2015-11-17 698 dev_err(dev, "failed to get itc-setting\n");
>
> :::::: The code at line 693 was first introduced by commit
> :::::: df96ed8dced21426c54c7f69cf7513e75280957a usb: chipidea: introduce ITC tuning interface
>
> :::::: TO: Peter Chen <peter.chen@freescale.com>
> :::::: CC: Peter Chen <peter.chen@freescale.com>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
next parent reply other threads:[~2015-11-17 12:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201511172007.DmGhbpj1%fengguang.wu@intel.com>
2015-11-17 12:58 ` Julia Lawall [this message]
2015-11-17 13:11 ` Saurabh Sengar
2015-11-17 11:20 [PATCH] " Måns Rullgård
2015-11-17 11:40 ` [PATCH v2] " Saurabh Sengar
2015-11-17 11:44 ` Måns Rullgård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1511171357090.2455@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Peter.Chen@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mans@mansr.com \
--cc=saurabh.truth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®