From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754511AbcANArx (ORCPT ); Wed, 13 Jan 2016 19:47:53 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:34241 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754464AbcANArw (ORCPT ); Wed, 13 Jan 2016 19:47:52 -0500 Date: Wed, 13 Jan 2016 16:47:50 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Manjeet Pawar cc: "linux-kernel@vger.kernel.org" , Vaneet Narang , AJEET YADAV , PANKAJ MISHRA Subject: Re: Re: [PATCH] meminfo:Don't Account Shared memory in MemAvailable In-Reply-To: <2098518429.1000641452657131091.JavaMail.weblogic@ep2mlwas04d> Message-ID: References: <2098518429.1000641452657131091.JavaMail.weblogic@ep2mlwas04d> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 Jan 2016, Manjeet Pawar wrote: > >> Instead of using watermark we should subtract SHMEM from pagecache for > >> accounting in available memory > >> > >> Signed-off-by: Vaneet Narang > >> Signed-off-by: Manjeet Pawar > >> Reviewed-by: Ajeet Yadav > > >What's missing from your commit description is: why? > Nothing is missing from the commit description, I think this is enough to explain about the patch. > Commit Description : Instead of using watermark we should subtract SHMEM from pagecache for accounting in available memory. NACK to your patch until proper justification for a user-facing change is provided.