From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755581AbcARPt3 (ORCPT ); Mon, 18 Jan 2016 10:49:29 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:42367 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755403AbcARPt1 (ORCPT ); Mon, 18 Jan 2016 10:49:27 -0500 X-IronPort-AV: E=Sophos;i="5.22,312,1449529200"; d="scan'208";a="197955358" Date: Mon, 18 Jan 2016 16:49:06 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Maarten Lankhorst cc: kbuild-all@01.org, Daniel Vetter , Jani Nikula , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/i915: fix itnull.cocci warnings (fwd) Message-ID: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org List_for_each entry binds its first argument to an offset from the list pointer, so this should not be NULL. Generated by: scripts/coccinelle/iterators/itnull.cocci Signed-off-by: Fengguang Wu --- Please take the patch only if it's a positive warning. Thanks! intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/drm/i915/intel_display.c @@ -16498,7 +16498,7 @@ void intel_modeset_preclose(struct drm_d struct intel_flip_work *work; list_for_each_entry(work, &crtc->flip_work, head) { - if (work && work->event && + if (work->event && work->event->base.file_priv == file) { kfree(work->event); work->event = NULL;