From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757405AbcASSyr (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 Jan 2016 13:54:47 -0500
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:58165 "EHLO
	mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1755507AbcASSyl (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 Jan 2016 13:54:41 -0500
X-IronPort-AV: E=Sophos;i="5.22,318,1449529200"; 
   d="scan'208";a="198186859"
Date: Tue, 19 Jan 2016 19:54:20 +0100 (CET)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: Shuah Khan <shuahkhan@gmail.com>
cc: Julia Lawall <julia.lawall@lip6.fr>, bh74.an@samsung.com,
        ks.giri@samsung.com, vipul.pandya@samsung.com, netdev@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>, shuahkh@osg.samsung.com
Subject: Re: question about samsung/sxgbe/sxgbe_xpcs.c
In-Reply-To: <CAKocOOOFrEFLL0MWnn_bhBby8GeVH82A2wtaL9Tg9QTJC2Wprw@mail.gmail.com>
Message-ID: <alpine.DEB.2.10.1601191918470.2531@hadrien>
References: <alpine.DEB.2.10.1601191723250.2531@hadrien> <CAKocOOOFrEFLL0MWnn_bhBby8GeVH82A2wtaL9Tg9QTJC2Wprw@mail.gmail.com>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On Tue, 19 Jan 2016, Shuah Khan wrote:

> 2016-01-19 9:26 GMT-07:00 Julia Lawall <julia.lawall@lip6.fr>:
> > Hello,
> >
> > I was windering what is the purpose of the file
> > drivers/net/ethernet/samsung/sxgbe/sxgbe_xpcs.c
>
> From git log and comments, it appears this driver is for
> Samsung SoCs.
>
> >
> > I can't find anything that refers to it, and if I remove it from the
> > makefile:
> >
> > @@ -1,4 +1,4 @@
> >  obj-$(CONFIG_SXGBE_ETH) += samsung-sxgbe.o
> >  samsung-sxgbe-objs:= sxgbe_platform.o sxgbe_main.o sxgbe_desc.o \
> >                 sxgbe_dma.o sxgbe_core.o sxgbe_mtl.o  sxgbe_mdio.o \
> > -               sxgbe_ethtool.o sxgbe_xpcs.o $(samsung-sxgbe-y)
> > +               sxgbe_ethtool.o $(samsung-sxgbe-y)
> >
> > and then make clean and recompile, I see no bad effect.
> >
>
> What is the motivation for the experiment to remove it?
> This file probably gets used only on Samsung SoCs.

I just wondered.  I was looking at dependencies between networking files.
This one stands out because nothing is dependenton it, even the files it
is compiled with, and it doesn't contain the usual functions,
register_netdev, etc.

Thanks for the explanation.

julia