From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932840AbcAYPWW (ORCPT ); Mon, 25 Jan 2016 10:22:22 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:30335 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751913AbcAYPWU (ORCPT ); Mon, 25 Jan 2016 10:22:20 -0500 X-IronPort-AV: E=Sophos;i="5.22,345,1449529200"; d="scan'208";a="199178209" Date: Mon, 25 Jan 2016 16:21:54 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Geliang Tang cc: linux-usb@vger.kernel.org, kbuild-all@01.org, Greg Kroah-Hartman , Felipe Balbi , Andrzej Pietrasiewicz , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] usb: gadget: rndis: fix itnull.cocci warnings Message-ID: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The index variable of list_for_each_entry_safe is an offset from a list pointer, and thus should not be NULL. Generated by: scripts/coccinelle/iterators/itnull.cocci CC: Geliang Tang Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing head: 0e781c2258ffb2a42bf44f62dea8662f38cbfd34 commit: f6281af9d62e128aa6efad29cf7265062af114f2 [27/38] usb: gadget: rndis: use list_for_each_entry_safe rndis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/gadget/function/rndis.c +++ b/drivers/usb/gadget/function/rndis.c @@ -1009,7 +1009,7 @@ void rndis_free_response(struct rndis_pa rndis_resp_t *r, *n; list_for_each_entry_safe(r, n, ¶ms->resp_queue, list) { - if (r && r->buf == buf) { + if (r->buf == buf) { list_del(&r->list); kfree(r); }