From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757876AbcBCXzp (ORCPT ); Wed, 3 Feb 2016 18:55:45 -0500 Received: from mail-pf0-f181.google.com ([209.85.192.181]:34097 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757131AbcBCXzn (ORCPT ); Wed, 3 Feb 2016 18:55:43 -0500 Date: Wed, 3 Feb 2016 15:55:40 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Vlastimil Babka cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Steven Rostedt , Peter Zijlstra , Arnaldo Carvalho de Melo , Ingo Molnar , Rasmus Villemoes , Joonsoo Kim , Minchan Kim , Sasha Levin , "Kirill A. Shutemov" , Mel Gorman , Michal Hocko Subject: Re: [PATCH v4 02/14] mm, tracing: make show_gfp_flags() up to date In-Reply-To: <1453812353-26744-3-git-send-email-vbabka@suse.cz> Message-ID: References: <1453812353-26744-1-git-send-email-vbabka@suse.cz> <1453812353-26744-3-git-send-email-vbabka@suse.cz> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Jan 2016, Vlastimil Babka wrote: > The show_gfp_flags() macro provides human-friendly printing of gfp flags in > tracepoints. However, it is somewhat out of date and missing several flags. > This patches fills in the missing flags, and distinguishes properly between > GFP_ATOMIC and __GFP_ATOMIC which were both translated to "GFP_ATOMIC". > More generally, all __GFP_X flags which were previously printed as GFP_X, are > now printed as __GFP_X, since ommiting the underscores results in output that > doesn't actually match the source code, and can only lead to confusion. Where > both variants are defined equal (e.g. _DMA and _DMA32), the variant without > underscores are preferred. > > Also add a note in gfp.h so hopefully future changes will be synced better. > > __GFP_MOVABLE is defined twice in include/linux/gfp.h with different comments. > Leave just the newer one, which was intended to replace the old one. > > Signed-off-by: Vlastimil Babka > Cc: Steven Rostedt > Cc: Peter Zijlstra > Cc: Arnaldo Carvalho de Melo > Cc: Ingo Molnar > Cc: Rasmus Villemoes > Cc: Joonsoo Kim > Cc: Minchan Kim > Cc: Sasha Levin > Cc: "Kirill A. Shutemov" > Cc: Mel Gorman > Reviewed-by: Michal Hocko Acked-by: David Rientjes