From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756103AbcBIJS3 (ORCPT ); Tue, 9 Feb 2016 04:18:29 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:48169 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753957AbcBIJSZ (ORCPT ); Tue, 9 Feb 2016 04:18:25 -0500 X-IronPort-AV: E=Sophos;i="5.22,420,1449529200"; d="scan'208";a="202231207" Date: Tue, 9 Feb 2016 10:18:22 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: SF Markus Elfring cc: Kris Borer , Michal Marek , Gilles Muller , Nicolas Palix , linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr Subject: Re: [PATCH v2] coccinelle: add style check for assignment in if In-Reply-To: <56B9A2F6.4040109@users.sourceforge.net> Message-ID: References: <1454935571-4054-1-git-send-email-kborer@gmail.com> <56B9A2F6.4040109@users.sourceforge.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 9 Feb 2016, SF Markus Elfring wrote: > > +virtual patch > > How do you think about to use this variable in a subsequent > SmPL rule? > > Would you like to consider also the reuse of SmPL variables > like "org" and "report"? I think that there is no point for these things, because checkpatch already gives warnings about this issue. It could be nice for the provided rules to actually depend on patch. But in the context of make coccicheck, it doesn't matter, because attempts to run the rule in another mode will just fail, due to the mode not being declared. julia