From: Julia Lawall <julia.lawall@lip6.fr>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
Yann Droneaud <ydroneaud@opteya.com>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Michal Marek <mmarek@suse.com>, Tejun Heo <tj@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: coccinelle: also catch kzfree() issues
Date: Tue, 16 Feb 2016 15:17:47 -0500 (EST) [thread overview]
Message-ID: <alpine.DEB.2.10.1602161516450.6722@hadrien> (raw)
In-Reply-To: <56C38049.7090205@users.sourceforge.net>
On Tue, 16 Feb 2016, SF Markus Elfring wrote:
> >> @free@
> >> +identifier kfree =~ "kz?free";
> >
> > Thanks for the suggestions. However, the regular expression is not such a
> > good idea.
>
> How much is such a SmPL constraint still usable then?
>
>
> > Coccinelle doesn't make any optimizations based on regulat expressions.
>
> Where can your software optimise the source code search?
When the name appears explicitly in the matching code, Coccinelle will
parse and process only files that contain that name.
julia
>
>
> > It would be better to put a disjunction with kfree and kzfree explicitly,
> > as in the other cases.
>
> What are the circumstances for corresponding benefits?
>
> Regards,
> Markus
>
next prev parent reply other threads:[~2016-02-16 20:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 17:01 [PATCH 0/3] coccinelle: catchup on memory allocation functions Yann Droneaud
2016-02-16 17:06 ` [PATCH 1/3] coccinelle: also catch kzfree() issues Yann Droneaud
2016-02-16 17:16 ` Julia Lawall
2016-02-16 20:02 ` SF Markus Elfring
2016-02-16 20:17 ` Julia Lawall [this message]
2016-02-16 20:22 ` SF Markus Elfring
2016-02-22 14:09 ` [PATCHv1 1/3] " Yann Droneaud
2016-02-22 14:20 ` Julia Lawall
2016-02-22 15:24 ` Yann Droneaud
2016-02-16 17:06 ` [PATCH 2/3] coccinelle: recognize more devm_* memory allocation functions Yann Droneaud
2016-02-16 17:18 ` Julia Lawall
2016-02-16 17:06 ` [PATCH 3/3] coccinelle: catch krealloc() on devm_*() allocated memory Yann Droneaud
2016-02-16 17:19 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1602161516450.6722@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=elfring@users.sourceforge.net \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=nicolas.palix@imag.fr \
--cc=tj@kernel.org \
--cc=ydroneaud@opteya.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®