From: Julia Lawall <julia.lawall@lip6.fr>
To: Vaishali Thakkar <vaishali.thakkar@oracle.com>
Cc: mmarek@suse.com, Gilles.Muller@lip6.fr, nicolas.palix@imag.fr,
linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr, nm@ti.com,
julia.lawall@lip6.fr
Subject: Re: [PATCH] Coccinelle: setup_timer: Add space in front of parentheses
Date: Sun, 20 Mar 2016 13:25:28 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.10.1603201325011.2597@hadrien> (raw)
In-Reply-To: <1458451652-5933-1-git-send-email-vaishali.thakkar@oracle.com>
On Sun, 20 Mar 2016, Vaishali Thakkar wrote:
> Add space in front of the offending parentheses to silent the
> parse error for older Coccinelle versions. This makes the rule
> usable with all Coccinelle versions.
>
> Reported-by: Nishanth Menon <nm@ti.com>
> Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> scripts/coccinelle/api/setup_timer.cocci | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/coccinelle/api/setup_timer.cocci b/scripts/coccinelle/api/setup_timer.cocci
> index 8ee0ac3..eb6bd9e 100644
> --- a/scripts/coccinelle/api/setup_timer.cocci
> +++ b/scripts/coccinelle/api/setup_timer.cocci
> @@ -106,7 +106,7 @@ position j0, j1, j2;
> @match_function_and_data_after_init_timer_context
> depends on !patch &&
> !match_immediate_function_data_after_init_timer_context &&
> -(context || org || report)@
> + (context || org || report)@
> expression a, b, e1, e2, e3, e4, e5;
> position j0, j1, j2;
> @@
> @@ -127,7 +127,7 @@ position j0, j1, j2;
> @r3_context depends on !patch &&
> !match_immediate_function_data_after_init_timer_context &&
> !match_function_and_data_after_init_timer_context &&
> -(context || org || report)@
> + (context || org || report)@
> expression c, e6, e7;
> position r1.p;
> position j0, j1;
> --
> 2.1.4
>
>
next prev parent reply other threads:[~2016-03-20 12:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-20 5:27 Vaishali Thakkar
2016-03-20 12:25 ` Julia Lawall [this message]
2016-04-20 7:51 ` Michal Marek
2016-04-12 21:25 ` [Cocci] " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1603201325011.2597@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=nicolas.palix@imag.fr \
--cc=nm@ti.com \
--cc=vaishali.thakkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®