From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758071AbcC2WN6 (ORCPT ); Tue, 29 Mar 2016 18:13:58 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:33975 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756665AbcC2WN5 (ORCPT ); Tue, 29 Mar 2016 18:13:57 -0400 Date: Tue, 29 Mar 2016 15:13:54 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Michal Hocko cc: linux-mm@kvack.org, Johannes Weiner , Tetsuo Handa , Andrew Morton , LKML , Michal Hocko Subject: Re: [RFC PATCH] mm, oom: move GFP_NOFS check to out_of_memory In-Reply-To: <1459258055-1173-1-git-send-email-mhocko@kernel.org> Message-ID: References: <1459258055-1173-1-git-send-email-mhocko@kernel.org> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Mar 2016, Michal Hocko wrote: > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 86349586eacb..1c2b7a82f0c4 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -876,6 +876,10 @@ bool out_of_memory(struct oom_control *oc) > return true; > } > > + /* The OOM killer does not compensate for IO-less reclaim. */ > + if (!(oc->gfp_mask & __GFP_FS)) > + return true; > + > /* > * Check if there were limitations on the allocation (only relevant for > * NUMA) that may require different handling. I don't object to this necessarily, but I think we need input from those that have taken the time to implement their own oom notifier to see if they agree. In the past, they would only be called if reclaim has completely failed; now, they can be called in low memory situations when reclaim has had very little chance to be successful. Getting an ack from them would be helpful. I also think we have discussed this before, but I think the oom notifier handling should be in done in the page allocator proper, i.e. in __alloc_pages_may_oom(). We can leave out_of_memory() for a clear defined purpose: to kill a process when all reclaim has failed.