From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932629AbcEQOeG (ORCPT <rfc822;w@1wt.eu>);
	Tue, 17 May 2016 10:34:06 -0400
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:60616
	"EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S932126AbcEQOeE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 17 May 2016 10:34:04 -0400
X-IronPort-AV: E=Sophos;i="5.26,324,1459807200"; 
   d="scan'208";a="178070235"
Date: Tue, 17 May 2016 16:33:58 +0200 (CEST)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: "Nicolas Palix (LIG)" <Nicolas.Palix@imag.fr>
cc: Kees Cook <keescook@chromium.org>, Julia Lawall <Julia.Lawall@lip6.fr>,
        linux-kernel@vger.kernel.org, Gilles Muller <Gilles.Muller@lip6.fr>,
        Michal Marek <mmarek@suse.com>, cocci@systeme.lip6.fr
Subject: Re: [PATCH] coccicheck: Fix missing 0 index in kill loop
In-Reply-To: <573B2B89.7060004@imag.fr>
Message-ID: <alpine.DEB.2.10.1605171633460.3068@hadrien>
References: <20160516125558.GA352@www.outflux.net> <573B2B89.7060004@imag.fr>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: MULTIPART/MIXED; BOUNDARY="8323329-294317989-1463495639=:3068"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-294317989-1463495639=:3068
Content-Type: TEXT/PLAIN; charset=windows-1252
Content-Transfer-Encoding: 8BIT



On Tue, 17 May 2016, Nicolas Palix (LIG) wrote:

> Le 16/05/16 14:55, Kees Cook a écrit :
> > By default, "seq" counts from 1, but processes were starting counting
> > from 0, so when interrupted, coccicheck would leave the 0th process
> > running.
> >
> > Signed-off-by: Kees Cook <keescook@chromium.org>
>
> Acked-by: Nicolas Palix <nicolas.palix@imag.fr>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

>
>
> > ---
> >  scripts/coccicheck | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/coccicheck b/scripts/coccicheck
> > index b2d758188f2f..dd85a455b2ba 100755
> > --- a/scripts/coccicheck
> > +++ b/scripts/coccicheck
> > @@ -98,7 +98,7 @@ run_cmd() {
> >  }
> >
> >  kill_running() {
> > -	for i in $(seq $(( NPROC - 1 )) ); do
> > +	for i in $(seq 0 $(( NPROC - 1 )) ); do
> >  		if [ $VERBOSE -eq 2 ] ; then
> >  			echo "Killing ${SPATCH_PID[$i]}"
> >  		fi
> >
>
>
> --
> Nicolas Palix
> http://lig-membres.imag.fr/palix/
>
>
--8323329-294317989-1463495639=:3068--