mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shrikrishna Khare <skhare@vmware.com>
To: Thomas Hellstrom <thellstrom@vmware.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	pv-drivers@vmware.com, Jin Heo <heoj@vmware.com>
Subject: Re: [Pv-drivers] [PATCH net v2] vmxnet3: segCnt can be 1 for LRO packets
Date: Wed, 8 Jun 2016 07:43:16 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.10.1606080741541.14228@shri-linux.eng.vmware.com> (raw)
In-Reply-To: <5757EEFC.3060709@vmware.com>



On Wed, 8 Jun 2016, Thomas Hellstrom wrote:

> >  				mss = rcdlro->mss;
> >  				if (unlikely(segCnt <= 1))
> >  					segCnt = 0;
> 
> Based on this code, it looks like it can handle the case without taking
> down the kernel completely, so instead of a
> "BUG_ON", would it make sense with a WARN_ON_ONCE() or WARN_ON()?

Thanks for the review Thomas. I fixed the code to use WARN_ON_ONCE. Sent 
out revised patch.

  reply	other threads:[~2016-06-08 14:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08  6:13 Shrikrishna Khare
2016-06-08 10:10 ` [Pv-drivers] " Thomas Hellstrom
2016-06-08 14:43   ` Shrikrishna Khare [this message]
2016-06-10  7:15 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1606080741541.14228@shri-linux.eng.vmware.com \
    --to=skhare@vmware.com \
    --cc=heoj@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pv-drivers@vmware.com \
    --cc=thellstrom@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®