From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964797AbcFONbc (ORCPT ); Wed, 15 Jun 2016 09:31:32 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:30394 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932130AbcFONbb (ORCPT ); Wed, 15 Jun 2016 09:31:31 -0400 X-IronPort-AV: E=Sophos;i="5.26,476,1459807200"; d="scan'208";a="181356114" Date: Wed, 15 Jun 2016 15:31:25 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Takashi Iwai cc: Amitoj Kaur Chawla , alsa-devel@alsa-project.org, perex@perex.cz, linux-kernel@vger.kernel.org, keescook@chromium.org, michael.leibowitz@intel.com Subject: Re: [PATCH] ALSA: usb-audio: Change structure initialisation to C99 style In-Reply-To: Message-ID: References: <20160615132634.GA20438@amitoj-Inspiron-3542> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Jun 2016, Takashi Iwai wrote: > On Wed, 15 Jun 2016 15:26:34 +0200, > Amitoj Kaur Chawla wrote: > > > > Replace the in order struct initialisation style with explicit field > > style. > > > > The Coccinelle semantic patch used to make this change is as follows: > > > > @decl@ > > identifier i1,fld; > > type T; > > field list[n] fs; > > @@ > > > > struct i1 { > > fs > > T fld; > > ...}; > > > > @@ > > identifier decl.i1,i2,decl.fld; > > expression e; > > position bad.p, bad.fix; > > @@ > > > > struct i1 i2@p = { ..., > > + .fld = e > > - e@fix > > ,...}; > > > > Signed-off-by: Amitoj Kaur Chawla > > --- > > sound/usb/mixer_maps.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c > > index 1f8fb0d9..9038b2e 100644 > > --- a/sound/usb/mixer_maps.c > > +++ b/sound/usb/mixer_maps.c > > @@ -107,8 +107,10 @@ static struct usbmix_name_map extigy_map[] = { > > * e.g. no Master and fake PCM volume > > * Pavel Mihaylov > > */ > > -static struct usbmix_dB_map mp3plus_dB_1 = {-4781, 0}; /* just guess */ > > -static struct usbmix_dB_map mp3plus_dB_2 = {-1781, 618}; /* just guess */ > > +static struct usbmix_dB_map mp3plus_dB_1 = {.min = -4781, .max = 0}; > > + /* just guess */ > > +static struct usbmix_dB_map mp3plus_dB_2 = {.min = -1781, .max = 618}; > > + /* just guess */ > > These are simple min/max table, so no big merit to write in such a > way. My understanding is that structures are going to be randomized, so at least all global structures need C99 initialization. Maybe Kees can provide further clarification. julia