From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751670AbcFUUgF (ORCPT ); Tue, 21 Jun 2016 16:36:05 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:33007 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835AbcFUUgB (ORCPT ); Tue, 21 Jun 2016 16:36:01 -0400 Date: Tue, 21 Jun 2016 13:27:40 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Ganesh Mahendran cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, arve@android.com, riandrews@android.com Subject: Re: [PATCH 1/3] staging: lowmemorykiller: change lowmem_adj to lowmem_score_adj In-Reply-To: <1466487018-5410-1-git-send-email-opensource.ganesh@gmail.com> Message-ID: References: <1466487018-5410-1-git-send-email-opensource.ganesh@gmail.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Jun 2016, Ganesh Mahendran wrote: > om_adj is deprecated, and in lowmemorykiller module, we use score adj > to do the comparing. > --- > oom_score_adj = p->signal->oom_score_adj; > if (oom_score_adj < min_score_adj) { > task_unlock(p); > continue; > } > --- > > This patch makes the variable name consistent with the usage. > Umm, I don't think you can just remove a parameter to a module and replace it with something that has a different unit and not think that userspace will break as a result.