From: David Rientjes <rientjes@google.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
glider@google.com, hughd@google.com, mgorman@techsingularity.net,
mhocko@kernel.org, minchan@kernel.org, vbabka@suse.cz,
mm-commits@vger.kernel.org
Subject: Re: + mm-compaction-split-freepages-without-holding-the-zone-lock-fix.patch added to -mm tree
Date: Tue, 21 Jun 2016 17:53:22 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1606211747270.88257@chino.kir.corp.google.com> (raw)
In-Reply-To: <20160622003543.GA25106@js1304-P5Q-DELUXE>
On Wed, 22 Jun 2016, Joonsoo Kim wrote:
> On Tue, Jun 21, 2016 at 04:14:28PM -0700, akpm@linux-foundation.org wrote:
> >
> > The patch titled
> > Subject: mm/compaction: split freepages without holding the zone lock fix
> > has been added to the -mm tree. Its filename is
> > mm-compaction-split-freepages-without-holding-the-zone-lock-fix.patch
> >
> > This patch should soon appear at
> > http://ozlabs.org/~akpm/mmots/broken-out/mm-compaction-split-freepages-without-holding-the-zone-lock-fix.patch
> > and later at
> > http://ozlabs.org/~akpm/mmotm/broken-out/mm-compaction-split-freepages-without-holding-the-zone-lock-fix.patch
> >
> > Before you just go and hit "reply", please:
> > a) Consider who else should be cc'ed
> > b) Prefer to cc a suitable mailing list as well
> > c) Ideally: find the original patch on the mailing list and do a
> > reply-to-all to that, adding suitable additional cc's
> >
> > *** Remember to use Documentation/SubmitChecklist when testing your code ***
> >
> > The -mm tree is included into linux-next and is updated
> > there every 3-4 working days
> >
> > ------------------------------------------------------
> > From: David Rientjes <rientjes@google.com>
> > Subject: mm/compaction: split freepages without holding the zone lock fix
> >
> > If __isolate_free_page() fails, avoid adding to freelist so we don't call
> > map_pages() with it.
> >
> > Link: http://lkml.kernel.org/r/alpine.DEB.2.10.1606211447001.43430@chino.kir.corp.google.com
>
> I've sent the fix already. I don't care which patch is merged but I guess
> below series would be merged more cleanly? It's up to Andrew.
>
> Link: http://lkml.kernel.org/r/1466150259-27727-1-git-send-email-iamjoonsoo.kim@lge.com
>
Well, http://marc.info/?l=linux-mm&m=146654572331344 fixes an issue that
persists at least as far back as 3.11 whereas we can scan entire 256GB+
zones needlessly each time compaction_alloc() is called, and that function
can be called multiple times for a single page isolated for migration in
the case of -EAGAIN. It's been measured that compaction_alloc() can take
15-20% of cpu cycles while faulting thp on very large machines back in the
3.11 kernel. I would suggest that this is an important fix that needs to
be included and perhaps backported to stable.
I don't know the relative importance the reducing the size of page_owner
patchset. It appears that the link you provided is a refreshed series of
a patchset that is already in -mm? If so, I think the old set should be
reverted, and whatever dependencies it has, and then a third version of
http://marc.info/?l=linux-mm&m=146654572331344 merged. I can propose that
for inclusion in this release cycle if folks agree that it's warranted.
The alternative seems to be to rebase your refreshed series on top of -mm
with the fix.
next prev parent reply other threads:[~2016-06-22 0:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5769ca54.gwMDbTOc4lLM8KUy%akpm@linux-foundation.org>
2016-06-22 0:35 ` Joonsoo Kim
2016-06-22 0:53 ` David Rientjes [this message]
2016-06-22 1:07 ` Joonsoo Kim
2016-06-22 1:09 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1606211747270.88257@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=glider@google.com \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®