From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751790AbcFVBKR (ORCPT ); Tue, 21 Jun 2016 21:10:17 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:33192 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750905AbcFVBKP (ORCPT ); Tue, 21 Jun 2016 21:10:15 -0400 Date: Tue, 21 Jun 2016 18:09:37 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Joonsoo Kim cc: linux-kernel@vger.kernel.org, Andrew Morton , glider@google.com, hughd@google.com, mgorman@techsingularity.net, mhocko@kernel.org, minchan@kernel.org, vbabka@suse.cz, mm-commits@vger.kernel.org Subject: Re: + mm-compaction-split-freepages-without-holding-the-zone-lock-fix.patch added to -mm tree In-Reply-To: <20160622010718.GC25106@js1304-P5Q-DELUXE> Message-ID: References: <5769ca54.gwMDbTOc4lLM8KUy%akpm@linux-foundation.org> <20160622003543.GA25106@js1304-P5Q-DELUXE> <20160622010718.GC25106@js1304-P5Q-DELUXE> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 22 Jun 2016, Joonsoo Kim wrote: > > Well, http://marc.info/?l=linux-mm&m=146654572331344 fixes an issue that > > persists at least as far back as 3.11 whereas we can scan entire 256GB+ > > zones needlessly each time compaction_alloc() is called, and that function > > can be called multiple times for a single page isolated for migration in > > the case of -EAGAIN. It's been measured that compaction_alloc() can take > > 15-20% of cpu cycles while faulting thp on very large machines back in the > > 3.11 kernel. I would suggest that this is an important fix that needs to > > be included and perhaps backported to stable. > > Agreed. > > > > > I don't know the relative importance the reducing the size of page_owner > > patchset. It appears that the link you provided is a refreshed series of > > a patchset that is already in -mm? If so, I think the old set should be > > reverted, and whatever dependencies it has, and then a third version of > > http://marc.info/?l=linux-mm&m=146654572331344 merged. I can propose that > > for inclusion in this release cycle if folks agree that it's warranted. > > > > The alternative seems to be to rebase your refreshed series on top of -mm > > with the fix. > > I think that page_owner patch is less important. Andrew, could you > revert whole series? I will refresh series on top of -mm with the > David's fix. > Ok, I'm not exactly sure what the result will look like, so I'll propose a version of http://marc.info/?l=linux-mm&m=146654572331344 against Linus's tree and suggest it be backported to stable. I think it should go into this release cycle as well, but I'll wait for you or Vlastimil to ack it and see if you agree.