From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752358AbcF1NuB (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Jun 2016 09:50:01 -0400
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:63725 "EHLO
	mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751947AbcF1NuA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Jun 2016 09:50:00 -0400
X-IronPort-AV: E=Sophos;i="5.26,541,1459807200"; 
   d="scan'208";a="224528603"
Date: Tue, 28 Jun 2016 15:49:50 +0200 (CEST)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: Evgeniy Polyakov <zbr@ioremap.net>
cc: Amitoj Kaur Chawla <amitoj1606@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] w1: Remove unneeded header file
In-Reply-To: <1848631467118640@web17g.yandex.ru>
Message-ID: <alpine.DEB.2.10.1606281549010.5105@hadrien>
References: <20160624061843.GA23431@amitoj-Inspiron-3542> <1848631467118640@web17g.yandex.ru>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 28 Jun 2016, Evgeniy Polyakov wrote:

> Hi
>
> 24.06.2016, 09:18, "Amitoj Kaur Chawla" <amitoj1606@gmail.com>:
> > Drop redundant include of moduleparam.h
> >
> > The Coccinelle semantic patch used to make this change is as follows:
> > @ includesmodule @
> > @@
> >
> > #include <linux/module.h>
> >
> > @ depends on includesmodule @
> > @@
> >
> > - #include <linux/moduleparam.h>
> >
> > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
>
> Looks good to me, but these @@ are pretty cryptic.

There are two rules.  The first checks for an include of module.h.  The
second depends on the success of the first one.  It removes and include o
moduleparam.h.

julia