From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932656AbcGDI6e (ORCPT ); Mon, 4 Jul 2016 04:58:34 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:17547 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932625AbcGDI6a (ORCPT ); Mon, 4 Jul 2016 04:58:30 -0400 X-IronPort-AV: E=Sophos;i="5.26,574,1459807200"; d="scan'208";a="183684435" Date: Mon, 4 Jul 2016 10:58:13 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Dan Carpenter cc: Kishon Vijay Abraham I , Chen-Yu Tsai , Christophe JAILLET , maxime.ripard@free-electrons.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] phy: fix error handling In-Reply-To: <20160704085102.GF32301@mwanda> Message-ID: References: <1467525332-12963-1-git-send-email-christophe.jaillet@wanadoo.fr> <00d5243a-0359-1dc7-e9aa-1ad8a9074821@wanadoo.fr> <577A15D2.5010103@ti.com> <20160704085102.GF32301@mwanda> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 4 Jul 2016, Dan Carpenter wrote: > On Mon, Jul 04, 2016 at 01:22:50PM +0530, Kishon Vijay Abraham I wrote: > > Hi, > > > > On Monday 04 July 2016 02:38 AM, Christophe JAILLET wrote: > > > I will resubmit in the coming days. > > > > > > return PTR_ERR(phy->clk); > > > should also be updated. > > > > while at that, also fix your $subject to something like > > "phy: sun9i-usb: fix error handling" > > > > Yes. Also the first patch should have used that same prefix. > 9c3b44302636 ('phy: Add driver to support individual USB PHYs on sun9i') > > We have this problem quite often, but other subsystems have fixed it > because they start using the correct prefix when the driver is added. > The second patch for this driver had the same issue: > 9c3b44302636 ('phy: Add driver to support individual USB PHYs on sun9i') Is there any hope to some day have a deterministic algorithm? Something that get_maintainers could figure out. julia