From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752243AbcHMIAZ (ORCPT ); Sat, 13 Aug 2016 04:00:25 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:29723 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbcHMIAY (ORCPT ); Sat, 13 Aug 2016 04:00:24 -0400 X-IronPort-AV: E=Sophos;i="5.28,514,1464645600"; d="scan'208";a="187562733" Date: Sat, 13 Aug 2016 10:00:19 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Amitoj Kaur Chawla cc: thierry.reding@gmail.com, airlied@linux.ie, swarren@wwwdotorg.org, gnurou@gmail.com, dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/tegra: dpaux: Modify error handling In-Reply-To: <20160813040020.GA11719@amitoj-Inspiron-3542> Message-ID: References: <20160813040020.GA11719@amitoj-Inspiron-3542> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 13 Aug 2016, Amitoj Kaur Chawla wrote: > devm_pinctrl_register returns an ERR_PTR in case of error and should > have an IS_ERR check instead of a null check. > > The Coccinelle semantic patch used to make this change is as follows: > @@ > expression e; > @@ > > e = devm_pinxtrl_register(...); Actually, there is a typo here. devm_pinxtrl_register should be devm_pinctrl_register. julia > if( > - !e > + IS_ERR(e) > ) > { > <+... > return > - ... > + PTR_ERR(e) > ; > ...+> > } > > Signed-off-by: Amitoj Kaur Chawla > --- > drivers/gpu/drm/tegra/dpaux.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c > index 059f409..2fde44c 100644 > --- a/drivers/gpu/drm/tegra/dpaux.c > +++ b/drivers/gpu/drm/tegra/dpaux.c > @@ -539,9 +539,9 @@ static int tegra_dpaux_probe(struct platform_device *pdev) > dpaux->desc.owner = THIS_MODULE; > > dpaux->pinctrl = devm_pinctrl_register(&pdev->dev, &dpaux->desc, dpaux); > - if (!dpaux->pinctrl) { > + if (IS_ERR(dpaux->pinctrl)) { > dev_err(&pdev->dev, "failed to register pincontrol\n"); > - return -ENODEV; > + return PTR_ERR(dpaux->pinctrl); > } > #endif > /* enable and clear all interrupts */ > -- > 1.9.1 > >