From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758136AbcILMIp (ORCPT ); Mon, 12 Sep 2016 08:08:45 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:22195 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756086AbcILMIm (ORCPT ); Mon, 12 Sep 2016 08:08:42 -0400 X-IronPort-AV: E=Sophos;i="5.30,322,1470693600"; d="scan'208";a="192841923" Date: Mon, 12 Sep 2016 14:08:38 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Giuseppe Cavallaro cc: joe@perches.com, kernel-janitors@vger.kernel.org, Alexandre Torgue , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 20/26] stmmac: pci: constify local structures In-Reply-To: <1473599168-30561-21-git-send-email-Julia.Lawall@lip6.fr> Message-ID: References: <1473599168-30561-1-git-send-email-Julia.Lawall@lip6.fr> <1473599168-30561-21-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 11 Sep 2016, Julia Lawall wrote: > For structure types defined in the same file or local header files, find > top-level static structure declarations that have the following > properties: > 1. Never reassigned. > 2. Address never taken > 3. Not passed to a top-level macro call > 4. No pointer or array-typed field passed to a function or stored in a > variable. > Declare structures having all of these properties as const. Please ignore this patch. Coccinelle incorrectly interpreted {PCI_VDEVICE(INTEL, STMMAC_QUARK_ID), (kernel_ulong_t)&quark_pci_info} as a bit and operation, since it did not recognize kernel_ulong_t as a type. julia > Done using Coccinelle. > Based on a suggestion by Joe Perches . > > Signed-off-by: Julia Lawall > > --- > The semantic patch seems too long for a commit log, but is in the cover > letter. > > drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c > index 56c8a23..5c612c3 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c > @@ -141,7 +141,7 @@ static struct stmmac_pci_dmi_data quark_pci_dmi_data[] = { > {} > }; > > -static struct stmmac_pci_info quark_pci_info = { > +static const struct stmmac_pci_info quark_pci_info = { > .setup = quark_default_data, > .dmi = quark_pci_dmi_data, > }; > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >