From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753816AbcITGPr (ORCPT ); Tue, 20 Sep 2016 02:15:47 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:43095 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751327AbcITGPp (ORCPT ); Tue, 20 Sep 2016 02:15:45 -0400 X-IronPort-AV: E=Sophos;i="5.30,366,1470693600"; d="scan'208";a="237463686" Date: Tue, 20 Sep 2016 08:15:42 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: mturquette@baylibre.com, sboyd@codeaurora.org cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: question about clk_hw_register_fixed_factor Message-ID: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, The function clk_hw_register_fixed_factor from drivers/clk/clk-fixed-factor.c contains: struct clk_init_data init; ... fix->hw.init = &init; ... hw = &fix->hw; ... return hw; It looks like hw would then contain a dangling pointer, to init. Should this be nulled out, or does it not matter because it is certain that no one will look at it anyway? Or did I miss a null assignment elsewhere? thanks, julia