From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755812AbcIUVKx (ORCPT ); Wed, 21 Sep 2016 17:10:53 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:33397 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754852AbcIUVKv (ORCPT ); Wed, 21 Sep 2016 17:10:51 -0400 Date: Wed, 21 Sep 2016 14:10:49 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: zijun_hu cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, zijun_hu@htc.com, tj@kernel.org, mingo@kernel.org, iamjoonsoo.kim@lge.com, mgorman@techsingularity.net Subject: Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area() In-Reply-To: <57E20B54.5020408@zoho.com> Message-ID: References: <57E20B54.5020408@zoho.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Sep 2016, zijun_hu wrote: > From: zijun_hu > > correct a few logic error for __insert_vmap_area() since the else > if condition is always true and meaningless > > in order to fix this issue, if vmap_area inserted is lower than one > on rbtree then walk around left branch; if higher then right branch > otherwise intersects with the other then BUG_ON() is triggered > Under normal operation, you're right that the "else if" conditional should always succeed: we don't want to BUG() unless there's a bug. The original code can catch instances when va->va_start == tmp_va->va_end where we should BUG(). Your code silently ignores it.