From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756408AbcIUWpZ (ORCPT ); Wed, 21 Sep 2016 18:45:25 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:34793 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756237AbcIUWpV (ORCPT ); Wed, 21 Sep 2016 18:45:21 -0400 Date: Wed, 21 Sep 2016 15:45:19 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: zijun_hu cc: zijun_hu@htc.com, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, tj@kernel.org, mingo@kernel.org, iamjoonsoo.kim@lge.com, mgorman@techsingularity.net Subject: Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area() In-Reply-To: <034db3ec-e2dc-a6da-6dab-f0803900e19d@zoho.com> Message-ID: References: <57E20B54.5020408@zoho.com> <034db3ec-e2dc-a6da-6dab-f0803900e19d@zoho.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Sep 2016, zijun_hu wrote: > >> correct a few logic error for __insert_vmap_area() since the else > >> if condition is always true and meaningless > >> > >> in order to fix this issue, if vmap_area inserted is lower than one > >> on rbtree then walk around left branch; if higher then right branch > >> otherwise intersects with the other then BUG_ON() is triggered > >> > > > > Under normal operation, you're right that the "else if" conditional should > > always succeed: we don't want to BUG() unless there's a bug. The original > > code can catch instances when va->va_start == tmp_va->va_end where we > > should BUG(). Your code silently ignores it. > > > Hmm, the BUG_ON() appears in the original code, i don't introduce it. > it maybe be better to consider va->va_start == tmp_va->va_end as normal case > and should not BUG_ON() it since the available range of vmap_erea include > the start boundary but the end, BTW, represented as [start, end) > We don't support inserting when va->va_start == tmp_va->va_end, plain and simple. There's no reason to do so. NACK to the patch.