From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756937AbcIUXPt (ORCPT ); Wed, 21 Sep 2016 19:15:49 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:35995 "EHLO mail-pf0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756259AbcIUXPs (ORCPT ); Wed, 21 Sep 2016 19:15:48 -0400 Date: Wed, 21 Sep 2016 16:15:42 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: zijun_hu cc: zijun_hu@htc.com, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, tj@kernel.org, mingo@kernel.org, iamjoonsoo.kim@lge.com, mgorman@techsingularity.net Subject: Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area() In-Reply-To: Message-ID: References: <57E20B54.5020408@zoho.com> <034db3ec-e2dc-a6da-6dab-f0803900e19d@zoho.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 22 Sep 2016, zijun_hu wrote: > > We don't support inserting when va->va_start == tmp_va->va_end, plain and > > simple. There's no reason to do so. NACK to the patch. > > > i am sorry i disagree with you because > 1) in almost all context of vmalloc, original logic treat the special case as normal > for example, __find_vmap_area() or alloc_vmap_area() The ranges are [start, end) like everywhere else. __find_vmap_area() is implemented as such for the passed address. The address is aligned in alloc_vmap_area(), there's no surprise here. The logic is correct in __insert_vmap_area().