From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162058AbdAEWzj (ORCPT ); Thu, 5 Jan 2017 17:55:39 -0500 Received: from mail-pg0-f52.google.com ([74.125.83.52]:34325 "EHLO mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034524AbdAEWzR (ORCPT ); Thu, 5 Jan 2017 17:55:17 -0500 Date: Thu, 5 Jan 2017 14:54:07 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Vlastimil Babka cc: Mel Gorman , Andrew Morton , Michal Hocko , Jonathan Corbet , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch] mm, thp: add new background defrag option In-Reply-To: Message-ID: References: <20170105101330.bvhuglbbeudubgqb@techsingularity.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 5 Jan 2017, Vlastimil Babka wrote: > Hmm that's probably why it's hard to understand, because "madvise > request" is just setting a vma flag, and the THP allocation (and defrag) > still happens at fault. > > I'm not a fan of either name, so I've tried to implement my own > suggestion. Turns out it was easier than expected, as there's no kernel > boot option for "defer", just for "enabled", so that particular worry > was unfounded. > > And personally I think that it's less confusing when one can enable defer > and madvise together (and not any other combination), than having to dig > up the difference between "defer" and "background". > I think allowing only two options to be combined amongst four available solo options is going to be confusing and then even more difficult for the user to understand what happens when they are combined. Thus, I think these options should only have one settable mode as they have always done. The kernel implementation takes less of a priority to userspace simplicitly, imo, and my patch actually cleans up much of the existing code and ends up adding fewer lines that yours. I consider it an improvement in itself. I don't see the benefit of allowing combined options.