From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752470AbdEAVhV (ORCPT ); Mon, 1 May 2017 17:37:21 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:36849 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752956AbdEAVhN (ORCPT ); Mon, 1 May 2017 17:37:13 -0400 Date: Mon, 1 May 2017 14:37:06 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Wei Yang cc: kirill@shutemov.name, bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, tj@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] x86/numa_emulation: assign physnode_mask directly from numa_nodes_parsed In-Reply-To: <20170411014223.GA35630@WeideMacBook-Pro.local> Message-ID: References: <20170410165652.50250-1-richard.weiyang@gmail.com> <20170410165652.50250-3-richard.weiyang@gmail.com> <20170411014223.GA35630@WeideMacBook-Pro.local> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Apr 2017, Wei Yang wrote: > On Mon, Apr 10, 2017 at 05:26:03PM -0700, David Rientjes wrote: > >On Tue, 11 Apr 2017, Wei Yang wrote: > > > >> According to current code path, numa_nodes_parsed is already setup when > >> numa_emucation() is called. > >> > >> x86_numa_init() > >> numa_init() > >> init_func() > >> > >> numa_emulation() > >> > >> numa_register_memblks() > >> > > > >s/numa_emucation/numa_emulation/, but I think everything above should just > >be reworded to say the following since it establishes the dependency: > > > >numa_init() has already called init_func(), which is responsible for > >setting numa_nodes_parsed, so use this nodemask instead of re-finding it > >when calling numa_emulation(). > > > > Yep, thanks. > > Looks your change log is better :-) > Thanks! Would it be possible to refresh the series and repost for the x86 maintainers?