From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750942AbdE3E3v (ORCPT ); Tue, 30 May 2017 00:29:51 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:34441 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbdE3E3u (ORCPT ); Tue, 30 May 2017 00:29:50 -0400 Date: Mon, 29 May 2017 21:29:48 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Konstantin Khlebnikov cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Tetsuo Handa , Andrew Morton , Roman Guschin Subject: Re: [PATCH v2] mm/oom_kill: count global and memory cgroup oom kills In-Reply-To: <149570810989.203600.9492483715840752937.stgit@buzz> Message-ID: References: <149570810989.203600.9492483715840752937.stgit@buzz> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 May 2017, Konstantin Khlebnikov wrote: > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 04c9143a8625..dd30a045ef5b 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -876,6 +876,11 @@ static void oom_kill_process(struct oom_control *oc, const char *message) > /* Get a reference to safely compare mm after task_unlock(victim) */ > mm = victim->mm; > mmgrab(mm); > + > + /* Raise event before sending signal: reaper must see this */ How is the oom reaper involved here? > + count_vm_event(OOM_KILL); > + mem_cgroup_count_vm_event(mm, OOM_KILL); > + > /* > * We should send SIGKILL before setting TIF_MEMDIE in order to prevent > * the OOM victim from depleting the memory reserves from the user