From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752689AbdFSU2C (ORCPT ); Mon, 19 Jun 2017 16:28:02 -0400 Received: from mail-pf0-f181.google.com ([209.85.192.181]:35478 "EHLO mail-pf0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752657AbdFSU2A (ORCPT ); Mon, 19 Jun 2017 16:28:00 -0400 Date: Mon, 19 Jun 2017 13:27:48 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Kirill Tkhai cc: linux-ia64@vger.kernel.org, avagin@virtuozzo.com, peterz@infradead.org, heiko.carstens@de.ibm.com, hpa@zytor.com, gorcunov@virtuozzo.com, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, x86@kernel.org, mingo@redhat.com, mattst88@gmail.com, fenghua.yu@intel.com, arnd@arndb.de, ink@jurassic.park.msu.ru, tglx@linutronix.de, rth@twiddle.net, tony.luck@intel.com, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, schwidefsky@de.ibm.com, davem@davemloft.net Subject: Re: [PATCH 0/7] rwsem: Implement down_read_killable() In-Reply-To: <149789463636.9059.16943955939303454611.stgit@localhost.localdomain> Message-ID: References: <149789463636.9059.16943955939303454611.stgit@localhost.localdomain> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Jun 2017, Kirill Tkhai wrote: > This series implements killable version of down_read() > similar to already existing down_write_killable() function. > Patches [1-2/7] add arch-independent low-level primitives > for the both rwsem types. > > Patches [3-6/7] add arch-dependent primitives for > the architectures, that use rwsem-xadd implementation. > The assembly code was modified in x86 case only, the rest > of architectures does not need such change. > > I tested the series in x86 (which uses RWSEM_XCHGADD_ALGORITHM > config option), and also the RWSEM_GENERIC_SPINLOCK case, > which were manually written in Kconfig. alpha, ia64 and s390 > are compile-tested only, but I believe, their changes are > pretty easy. Please, people, who work with them, take your > look at the corresponding patches. > I would have expected to see down_read_killable() actually used somewhere after its implementation as part of this patchset.