From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752868AbdHOAtI (ORCPT ); Mon, 14 Aug 2017 20:49:08 -0400 Received: from mail-pg0-f45.google.com ([74.125.83.45]:33216 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752740AbdHOAtG (ORCPT ); Mon, 14 Aug 2017 20:49:06 -0400 Date: Mon, 14 Aug 2017 17:49:04 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Michal Hocko cc: Andrew Morton , Andrea Argangeli , "Kirill A. Shutemov" , Tetsuo Handa , Oleg Nesterov , Wenwei Tao , linux-mm@kvack.org, LKML , Michal Hocko Subject: Re: [PATCH 1/2] mm: fix double mmap_sem unlock on MMF_UNSTABLE enforced SIGBUS In-Reply-To: <20170807113839.16695-2-mhocko@kernel.org> Message-ID: References: <20170807113839.16695-1-mhocko@kernel.org> <20170807113839.16695-2-mhocko@kernel.org> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Aug 2017, Michal Hocko wrote: > From: Michal Hocko > > Tetsuo Handa has noticed that MMF_UNSTABLE SIGBUS path in > handle_mm_fault causes a lockdep splat > [ 58.539455] Out of memory: Kill process 1056 (a.out) score 603 or sacrifice child > [ 58.543943] Killed process 1056 (a.out) total-vm:4268108kB, anon-rss:2246048kB, file-rss:0kB, shmem-rss:0kB > [ 58.544245] a.out (1169) used greatest stack depth: 11664 bytes left > [ 58.557471] DEBUG_LOCKS_WARN_ON(depth <= 0) > [ 58.557480] ------------[ cut here ]------------ > [ 58.564407] WARNING: CPU: 6 PID: 1339 at kernel/locking/lockdep.c:3617 lock_release+0x172/0x1e0 > [ 58.599401] CPU: 6 PID: 1339 Comm: a.out Not tainted 4.13.0-rc3-next-20170803+ #142 > [ 58.604126] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 07/02/2015 > [ 58.609790] task: ffff9d90df888040 task.stack: ffffa07084854000 > [ 58.613944] RIP: 0010:lock_release+0x172/0x1e0 > [ 58.617622] RSP: 0000:ffffa07084857e58 EFLAGS: 00010082 > [ 58.621533] RAX: 000000000000001f RBX: ffff9d90df888040 RCX: 0000000000000000 > [ 58.626074] RDX: 0000000000000000 RSI: 0000000000000001 RDI: ffffffffa30d4ba4 > [ 58.630572] RBP: ffffa07084857e98 R08: 0000000000000000 R09: 0000000000000001 > [ 58.635016] R10: 0000000000000000 R11: 000000000000001f R12: ffffa07084857f58 > [ 58.639694] R13: ffff9d90f60d6cd0 R14: 0000000000000000 R15: ffffffffa305cb6e > [ 58.644200] FS: 00007fb932730740(0000) GS:ffff9d90f9f80000(0000) knlGS:0000000000000000 > [ 58.648989] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 58.652903] CR2: 000000000040092f CR3: 0000000135229000 CR4: 00000000000606e0 > [ 58.657280] Call Trace: > [ 58.659989] up_read+0x1a/0x40 > [ 58.662825] __do_page_fault+0x28e/0x4c0 > [ 58.665946] do_page_fault+0x30/0x80 > [ 58.668911] page_fault+0x28/0x30 > > The reason is that the page fault path might have dropped the mmap_sem > and returned with VM_FAULT_RETRY. MMF_UNSTABLE check however rewrites > the error path to VM_FAULT_SIGBUS and we always expect mmap_sem taken in > that path. Fix this by taking mmap_sem when VM_FAULT_RETRY is held in > the MMF_UNSTABLE path. We cannot simply add VM_FAULT_SIGBUS to the > existing error code because all arch specific page fault handlers and > g-u-p would have to learn a new error code combination. > > Reported-by: Tetsuo Handa > Fixes: 3f70dc38cec2 ("mm: make sure that kthreads will not refault oom reaped memory") > Cc: stable # 4.9+ > Signed-off-by: Michal Hocko Acked-by: David Rientjes