From: Stefano Stabellini <sstabellini@kernel.org>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
xen-devel@lists.xen.org, linux-kernel@vger.kernel.org,
jgross@suse.com, Stefano Stabellini <stefano@aporeto.com>
Subject: Re: [PATCH v4 02/13] xen/pvcalls: implement frontend disconnect
Date: Fri, 6 Oct 2017 13:29:12 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1710061328170.3073@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <4aa02396-b2b6-dd89-b83c-32e6919c8f18@oracle.com>
On Fri, 6 Oct 2017, Boris Ostrovsky wrote:
> On 10/06/2017 01:51 PM, Stefano Stabellini wrote:
> > On Wed, 20 Sep 2017, Boris Ostrovsky wrote:
> >>> +
> >>> +struct pvcalls_bedata {
> >>> + struct xen_pvcalls_front_ring ring;
> >>> + grant_ref_t ref;
> >>> + int irq;
> >>> +
> >>> + struct list_head socket_mappings;
> >>> + struct list_head socketpass_mappings;
> >>> + spinlock_t socket_lock;
> >>> +
> >>> + wait_queue_head_t inflight_req;
> >>> + struct xen_pvcalls_response rsp[PVCALLS_NR_REQ_PER_RING];
> >>> +};
> >>> +static struct xenbus_device *pvcalls_front_dev;
> >>> +static atomic_t pvcalls_refcount;
> >> Should the refcount be per back/frontend?
> > Yes it is, but only one back/frontend connection is supported by the
> > frontend. I can add a comment.
>
> Since it's per backend connection --- shouldn't it be part of struct
> pvcalls_bedata?
struct pvcalls_bedata is allocated with kzalloc. To protect accesses to
it, pvcalls_refcount needs to be outside of it.
next prev parent reply other threads:[~2017-10-06 20:29 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 23:00 [PATCH v4 00/13] introduce the Xen PV Calls frontend Stefano Stabellini
2017-09-15 23:00 ` [PATCH v4 01/13] xen/pvcalls: introduce the pvcalls xenbus frontend Stefano Stabellini
2017-09-15 23:00 ` [PATCH v4 02/13] xen/pvcalls: implement frontend disconnect Stefano Stabellini
2017-09-20 20:32 ` Boris Ostrovsky
2017-10-06 17:51 ` Stefano Stabellini
2017-10-06 20:21 ` Boris Ostrovsky
2017-10-06 20:29 ` Stefano Stabellini [this message]
2017-10-06 20:31 ` Boris Ostrovsky
2017-09-20 20:59 ` Boris Ostrovsky
2017-10-07 0:08 ` Stefano Stabellini
2017-09-15 23:00 ` [PATCH v4 03/13] xen/pvcalls: connect to the backend Stefano Stabellini
2017-09-20 21:08 ` Boris Ostrovsky
2017-09-15 23:00 ` [PATCH v4 04/13] xen/pvcalls: implement socket command and handle events Stefano Stabellini
2017-09-21 17:42 ` Boris Ostrovsky
2017-10-06 18:38 ` Stefano Stabellini
2017-10-06 20:36 ` Boris Ostrovsky
2017-09-15 23:00 ` [PATCH v4 05/13] xen/pvcalls: implement connect command Stefano Stabellini
2017-09-21 18:28 ` Boris Ostrovsky
2017-10-06 17:44 ` Stefano Stabellini
2017-10-06 17:54 ` Stefano Stabellini
2017-09-15 23:00 ` [PATCH v4 06/13] xen/pvcalls: implement bind command Stefano Stabellini
2017-09-21 19:40 ` Boris Ostrovsky
2017-10-06 20:35 ` Stefano Stabellini
2017-09-15 23:00 ` [PATCH v4 07/13] xen/pvcalls: implement listen command Stefano Stabellini
2017-09-15 23:00 ` [PATCH v4 08/13] xen/pvcalls: implement accept command Stefano Stabellini
2017-09-22 0:00 ` Boris Ostrovsky
2017-10-06 22:06 ` Stefano Stabellini
2017-09-15 23:00 ` [PATCH v4 09/13] xen/pvcalls: implement sendmsg Stefano Stabellini
2017-09-22 21:57 ` Boris Ostrovsky
2017-10-06 21:43 ` Stefano Stabellini
2017-09-15 23:00 ` [PATCH v4 10/13] xen/pvcalls: implement recvmsg Stefano Stabellini
2017-09-22 22:05 ` Boris Ostrovsky
2017-10-06 20:46 ` Stefano Stabellini
2017-09-15 23:00 ` [PATCH v4 11/13] xen/pvcalls: implement poll command Stefano Stabellini
2017-09-19 15:19 ` Andrea Parri
2017-10-06 23:33 ` Stefano Stabellini
2017-09-22 22:27 ` Boris Ostrovsky
2017-10-06 23:39 ` Stefano Stabellini
2017-09-15 23:00 ` [PATCH v4 12/13] xen/pvcalls: implement release command Stefano Stabellini
2017-09-22 22:43 ` Boris Ostrovsky
2017-09-22 22:48 ` Boris Ostrovsky
2017-10-06 23:49 ` Stefano Stabellini
2017-09-15 23:00 ` [PATCH v4 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1710061328170.3073@sstabellini-ThinkPad-X260 \
--to=sstabellini@kernel.org \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano@aporeto.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®