From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764617AbdJQWjM (ORCPT ); Tue, 17 Oct 2017 18:39:12 -0400 Received: from mail-io0-f172.google.com ([209.85.223.172]:54365 "EHLO mail-io0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754357AbdJQWjL (ORCPT ); Tue, 17 Oct 2017 18:39:11 -0400 X-Google-Smtp-Source: ABhQp+TrLOQ2Bq8vt5UCgKeTkOZsuWcKvmtJ+wYWWvJJkmSLTfdYEnmMVF/VVUTTrgaQxoP5X3tlZQ== Date: Tue, 17 Oct 2017 15:39:08 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Yang Shi cc: Michal Hocko , cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory In-Reply-To: Message-ID: References: <1507656303-103845-1-git-send-email-yang.s@alibaba-inc.com> <1507656303-103845-4-git-send-email-yang.s@alibaba-inc.com> <20171017074448.qupoajpjbcfdpz5z@dhcp22.suse.cz> <7ac4f9f6-3c3d-c1df-e60f-a519650cd330@alibaba-inc.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Oct 2017, Yang Shi wrote: > > Yes, this should catch occurrences of "huge unreclaimable slabs", right? > > Yes, it sounds so. Although single "huge" unreclaimable slab might not result > in excessive slabs use in a whole, but this would help to filter out "small" > unreclaimable slab. > Keep in mind this is regardless of SLAB_RECLAIM_ACCOUNT: your patch has value beyond only unreclaimable slab, it can also be used to show instances where the oom killer was invoked without properly reclaiming slab. If the total footprint of a slab cache exceeds 5%, I think a line should be emitted unconditionally to the kernel log.