From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753143AbdK1VtP (ORCPT ); Tue, 28 Nov 2017 16:49:15 -0500 Received: from ex13-edg-ou-002.vmware.com ([208.91.0.190]:45417 "EHLO EX13-EDG-OU-002.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751680AbdK1VtM (ORCPT ); Tue, 28 Nov 2017 16:49:12 -0500 Date: Tue, 28 Nov 2017 13:49:12 -0800 From: Shrikrishna Khare To: Andrew Lunn CC: Shrikrishna Khare , , , , Subject: Re: [PATCH net-next] vmxnet3: increase default rx ring sizes In-Reply-To: <20171128213327.GJ14512@lunn.ch> Message-ID: References: <20171128211204.12234-1-skhare@vmware.com> <20171128213327.GJ14512@lunn.ch> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Nov 2017, Andrew Lunn wrote: > > /* > > * Version numbers > > */ > > -#define VMXNET3_DRIVER_VERSION_STRING "1.4.a.0-k" > > +#define VMXNET3_DRIVER_VERSION_STRING "1.4.11.0-k" > > > > /* a 32-bit int, each byte encode a verion number in VMXNET3_DRIVER_VERSION */ > > -#define VMXNET3_DRIVER_VERSION_NUM 0x01040a00 > > +#define VMXNET3_DRIVER_VERSION_NUM 0x01040b00 > > Version strings in drivers are totally pointless, but should not this > be 0x01041100? > Version number is hex value written to vmxnet3 emulation, thus 0x1040b00 is correct (0x0b = 11). The VERSION_STRING should have previously been "1.4.10.0-k", this patch rectifies that by setting correct value "1.4.11.0-k". I will let John Savanyo (cc'ed) comment on having the version in the driver part. Thanks, Shri