From: Christoph Lameter <cl@gentwo.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andrey Ryabinin <a.ryabinin@samsung.com>,
ryabinin.a.a@gmail.com, Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Konstantin Khlebnikov <koct9i@gmail.com>
Subject: Re: [PATCH] mm: slub: SLUB_DEBUG=n: use the same alloc/free hooks as for SLUB_DEBUG=y
Date: Fri, 20 Jun 2014 09:29:23 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.11.1406200925360.10271@gentwo.org> (raw)
In-Reply-To: <20140619140651.c3c49cf70a7f349db595239e@linux-foundation.org>
On Thu, 19 Jun 2014, Andrew Morton wrote:
> (Is that a nack?)
Not sure.
> The intent seems to have been implemented strangely. Perhaps it would
> be clearer and more conventional to express all this using Kconfig
> logic.
Well it really does not work right since SLUB_DEBUG=y is the default
config and this behavior would be a bit surprising.
> Anyway, if we plan to leave the code as-is then can we please get a
> comment in there so the next person is not similarly confused?
Ok. Lets apply the patch.
Gosh. I think we need some way to figure out if code is being added to the
critical paths. I had no idea about that latest issue where might_sleep
suddenly became a call to cond_resched() until I saw the bug report.
prev parent reply other threads:[~2014-06-20 14:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 15:52 Andrey Ryabinin
2014-06-19 20:56 ` Christoph Lameter
2014-06-19 21:06 ` Andrew Morton
2014-06-19 21:26 ` Andrey Ryabinin
2014-06-20 14:29 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1406200925360.10271@gentwo.org \
--to=cl@gentwo.org \
--cc=a.ryabinin@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=ryabinin.a.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®