From: Christoph Lameter <cl@linux.com>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Fengguang Wu <fengguang.wu@intel.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Motohiro Kosaki <Motohiro.Kosaki@us.fujitsu.com>,
Mike Travis <travis@sgi.com>
Subject: Re: percpu: Define this_cpu_cpumask_var_t_ptr
Date: Tue, 26 Aug 2014 16:33:28 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.11.1408261631350.8819@gentwo.org> (raw)
In-Reply-To: <alpine.DEB.2.11.1408231500430.31459@gentwo.org>
On Sat, 23 Aug 2014, Christoph Lameter wrote:
> On Sat, 23 Aug 2014, Tejun Heo wrote:
>
> > Hello, Christoph.
> >
> > On Fri, Aug 22, 2014 at 12:43:25PM -0500, Christoph Lameter wrote:
> > > It wont accept the wrong type since the this_cpu_* functions will do type
> > > checking.
> >
> > It should only accept cpumask_var_t but the macro version accepts
> > anything that this_cpu_*() can handle.
>
> Ah, Ok.
Ok I tried to change it to an inline function. The problem is the
cpumask.h is included very early. this_cpu ops require functionality
that is not available at that point. I think it cannot be more than a
macro unless we define it elsewhere.
Regarding naming:
this_cpu_ptr_cpumask_var()
is ok?
next prev parent reply other threads:[~2014-08-26 21:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 15:05 Christoph Lameter
2014-08-08 19:46 ` Christoph Lameter
2014-08-21 22:22 ` Tejun Heo
2014-08-22 1:03 ` Christoph Lameter
2014-08-22 16:40 ` Tejun Heo
2014-08-22 17:43 ` Christoph Lameter
2014-08-23 17:14 ` Tejun Heo
2014-08-23 20:00 ` Christoph Lameter
2014-08-26 21:33 ` Christoph Lameter [this message]
2014-08-26 21:37 ` Tejun Heo
2014-08-26 23:04 ` Christoph Lameter
2014-08-27 0:12 ` Christoph Lameter
2014-08-28 13:02 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1408261631350.8819@gentwo.org \
--to=cl@linux.com \
--cc=Motohiro.Kosaki@us.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®