From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752674AbaIAVP4 (ORCPT ); Mon, 1 Sep 2014 17:15:56 -0400 Received: from qmta05.emeryville.ca.mail.comcast.net ([76.96.30.48]:51085 "EHLO qmta05.emeryville.ca.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752393AbaIAVPy (ORCPT ); Mon, 1 Sep 2014 17:15:54 -0400 Date: Mon, 1 Sep 2014 16:15:52 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@gentwo.org To: Guenter Roeck cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo Subject: Re: linux-next: Tree for Aug 29 In-Reply-To: <20140901173521.GA8259@roeck-us.net> Message-ID: References: <20140829150713.50d78c30@canb.auug.org.au> <20140901173521.GA8259@roeck-us.net> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Sep 2014, Guenter Roeck wrote: > arch/ia64/sn/kernel/setup.c: In function 'sn_cpu_init': > arch/ia64/sn/kernel/setup.c:632:13: error: lvalue required as left operand of assignment > make[1]: *** [arch/ia64/sn/kernel/setup.o] Error 1 > make: *** [arch/ia64/sn/kernel/setup.o] Error 2 Subject: ia64: sn_nodepda cannot be assigned to after this_cpu conversion. Use __this_cpu_write. There must be an explit statement to modify the percpu variable after the conversion of the sn_nodpda macro to use this_cpu_read. Signed-off-by: Christoph Lameter Index: linux/arch/ia64/sn/kernel/setup.c =================================================================== --- linux.orig/arch/ia64/sn/kernel/setup.c +++ linux/arch/ia64/sn/kernel/setup.c @@ -629,7 +629,7 @@ void sn_cpu_init(void) cnode = nasid_to_cnodeid(nasid); - sn_nodepda = nodepdaindr[cnode]; + __this_cpu_write(__sn_nodepda, nodepdaindr[cnode]); pda->led_address = (typeof(pda->led_address)) (LED0 + (slice << LED_CPU_SHIFT));