From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754117AbaIBOH3 (ORCPT ); Tue, 2 Sep 2014 10:07:29 -0400 Received: from qmta08.emeryville.ca.mail.comcast.net ([76.96.30.80]:60160 "EHLO qmta08.emeryville.ca.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752791AbaIBOH0 (ORCPT ); Tue, 2 Sep 2014 10:07:26 -0400 Date: Tue, 2 Sep 2014 09:07:23 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@gentwo.org To: Bartlomiej Zolnierkiewicz cc: Mark Brown , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, nicolas.pitre@linaro.org, Russell King , Tejun Heo , Kyungmin Park Subject: Re: linux-next: Tree for Sep 1 In-Reply-To: <1627064.QhxvejlWdk@amdc1032> Message-ID: References: <20140901230728.GM29327@sirena.org.uk> <1627064.QhxvejlWdk@amdc1032> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Sep 2014, Bartlomiej Zolnierkiewicz wrote: > Commit 532d0d0690d1 ("irqchips: Replace __this_cpu_ptr uses") > incorrectly converted *__this_cpu_ptr() to raw_cpu_read() instead > of *raw_cpu_ptr(). Fix it. Oww.. This is double indirection deal there. A percpu offset pointing to a pointer? Generally the following is true (definition from include/asm-generic/percpu.h that is used for ARM for raw_cpu_read): #define raw_cpu_read_4(pcp) (*raw_cpu_ptr(&(pcp))) > Index: b/drivers/irqchip/irq-gic.c > =================================================================== > --- a/drivers/irqchip/irq-gic.c 2014-09-02 14:03:41.026758653 +0200 > +++ b/drivers/irqchip/irq-gic.c 2014-09-02 14:37:04.466811546 +0200 > @@ -102,7 +102,7 @@ static struct gic_chip_data gic_data[MAX > #ifdef CONFIG_GIC_NON_BANKED > static void __iomem *gic_get_percpu_base(union gic_base *base) > { > - return raw_cpu_read(base->percpu_base); > + return *raw_cpu_ptr(base->percpu_base); > } > > static void __iomem *gic_get_common_base(union gic_base *base) > >