mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Scot Doyle <lkml14@scotdoyle.com>
To: Alan Stern <stern@rowland.harvard.edu>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sarah Sharp <sarah.a.sharp@linux.intel.com>,
	Dan Williams <dan.j.williams@intel.com>
Cc: Daniel Mack <daniel@caiaq.de>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] usb: core: downgrade log severity to info when descriptor unavailable
Date: Tue, 23 Sep 2014 19:12:40 +0000 (UTC)	[thread overview]
Message-ID: <alpine.DEB.2.11.1409231909590.7196@localhost.localdomain> (raw)
In-Reply-To: <alpine.DEB.2.11.1409231905460.3223@localhost.localdomain>

According to commit 0cce2eda19923e5e5ccc8b042dec5af87b3ffad0
    USB: fix LANGID=0 regression

usb devices are not required to report string descriptors. Since they are
optional, log an info message instead of an error message.

Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>
---
 drivers/usb/core/message.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
index 0c8a7fc..da2f1f2 100644
--- a/drivers/usb/core/message.c
+++ b/drivers/usb/core/message.c
@@ -780,8 +780,12 @@ static int usb_get_langid(struct usb_device *dev, unsigned char *tbuf)
 	 * deal with strings at all. Set string_langid to -1 in order to
 	 * prevent any string to be retrieved from the device */
 	if (err < 0) {
-		dev_err(&dev->dev, "string descriptor 0 read error: %d\n",
-					err);
+		if (err == -EPIPE)
+			dev_info(&dev->dev,
+				 "string descriptor 0 read error: -EPIPE\n");
+		else
+			dev_err(&dev->dev,
+				"string descriptor 0 read error: %d\n", err);
 		dev->string_langid = -1;
 		return -EPIPE;
 	}
-- 
2.1.0


  reply	other threads:[~2014-09-23 19:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-22 20:20 [PATCH] usb: core: downgrade log severity to info when descriptor missing Scot Doyle
2014-09-23 14:26 ` Alan Stern
2014-09-23 19:06   ` Scot Doyle
2014-09-23 19:12     ` Scot Doyle [this message]
2014-09-24  5:18       ` [PATCH v2] usb: core: downgrade log severity to info when descriptor unavailable Greg Kroah-Hartman
2014-09-24 17:56         ` Scot Doyle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1409231909590.7196@localhost.localdomain \
    --to=lkml14@scotdoyle.com \
    --cc=dan.j.williams@intel.com \
    --cc=daniel@caiaq.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sarah.a.sharp@linux.intel.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®