From: Thomas Gleixner <tglx@linutronix.de>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: daniel.lezcano@linaro.org, john.stultz@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] clocksource: Add BE APIs support for clocksource counter reading.
Date: Fri, 26 Sep 2014 15:34:08 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1409261521340.4567@nanos> (raw)
In-Reply-To: <1411712529-35293-1-git-send-email-Li.Xiubo@freescale.com>
On Fri, 26 Sep 2014, Xiubo Li wrote:
> For now I just added _be() support using ioread{16,32}be.
> And i have a check of the clocksource drivers, didn't find anyone
> using LE mode on one BE SoC, so _le() APIs is not needed.
Nonsense. The existing clocksource_mmio accessor function are
providing LE access independent of the CPU endianess. So we don't need
an _le() API simply because we have it already.
> cycle_t clocksource_mmio_readl_up(struct clocksource *c)
> {
> - return (cycle_t)readl_relaxed(to_mmio_clksrc(c)->reg);
> + return (cycle_t)ioread32(to_mmio_clksrc(c)->reg);
And how exactly is this change related to adding BE support?
Thanks,
tglx
next prev parent reply other threads:[~2014-09-26 13:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 6:22 Xiubo Li
2014-09-26 13:34 ` Thomas Gleixner [this message]
2014-09-28 2:39 ` Li.Xiubo
2014-09-29 22:38 ` Thomas Gleixner
2014-09-30 2:12 ` Li.Xiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1409261521340.4567@nanos \
--to=tglx@linutronix.de \
--cc=Li.Xiubo@freescale.com \
--cc=daniel.lezcano@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®