mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "pang.xunlei" <pang.xunlei@linaro.org>
Cc: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
	John Stultz <john.stultz@linaro.org>,
	Alessandro Zummo <a.zummo@towertech.it>
Subject: Re: [PATCH RFC 01/12] time: Rename mktime() to mktime_unsafe()
Date: Mon, 27 Oct 2014 22:38:19 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.11.1410272223330.5308@nanos> (raw)
In-Reply-To: <1414388748-3333-1-git-send-email-pang.xunlei@linaro.org>

On Mon, 27 Oct 2014, pang.xunlei wrote:

> The kernel uses 32-bit signed value(time_t) for seconds since 1970-01-01:00:00:00, thus it
> will overflow at 2038-01-19 03:14:08 on 32-bit systems. We call this "2038 safety" issue.
> 
> Currently, mktime() deals with "unsigned long" which is 2038 unsafe on 32-bit systems.
> 
> As part of addressing 2038 saftey for in-kernel uses, this patch renames mktime() to
> mktime_unsafe(), and changes all its calling users correspondingly. The safe version
> of mktime() will be added in the following patch.

This is a flag day change. We really want to avoid that. Can we please
add a new interface first, then convert all the existing users and
kill the old interface.

If we really care we can rename it back to the old name once all that
has been done, but I personally do not care whether its mktime or
mktime64 as long as it is fixed proper.

Thanks,

	tglx



  reply	other threads:[~2014-10-27 21:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-27  5:45 pang.xunlei
2014-10-27 21:38 ` Thomas Gleixner [this message]
2014-10-27 21:54   ` John Stultz
2014-10-27 22:11     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1410272223330.5308@nanos \
    --to=tglx@linutronix.de \
    --cc=a.zummo@towertech.it \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pang.xunlei@linaro.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®