From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753919AbaJ1UwH (ORCPT ); Tue, 28 Oct 2014 16:52:07 -0400 Received: from www.linutronix.de ([62.245.132.108]:52296 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030AbaJ1UwF (ORCPT ); Tue, 28 Oct 2014 16:52:05 -0400 Date: Tue, 28 Oct 2014 21:52:02 +0100 (CET) From: Thomas Gleixner To: Arnd Bergmann cc: Heena Sirwani , linux-kernel@vger.kernel.org, john.stultz@linaro.org Subject: Re: [PATCH v2] timekeeping: Added a function to return tv_sec portion of ktime_get_real_ts64() In-Reply-To: <1825407.TtFpTslzjC@wuerfel> Message-ID: References: <20141027050804.GA8550@heena-HP-Compaq-8200-Elite-MT-PC> <9160485.26T1OFaUNG@wuerfel> <1825407.TtFpTslzjC@wuerfel> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Oct 2014, Arnd Bergmann wrote: > On Tuesday 28 October 2014 21:31:32 Thomas Gleixner wrote: > > On Tue, 28 Oct 2014, Arnd Bergmann wrote: > > > On Tuesday 28 October 2014 18:13:09 Thomas Gleixner wrote: > > > I'd like to apply this patch to my y2038 branch and apply the > > > other patches that need it on top, unless you want to still submit > > > it for 3.18. > > > > I think I should take these patches for 3.18. We do not create users > > yet, but it makes it easier for submaintaners to apply stuff which you > > convert. And it lets me have the whole core lot together with other > > changes in that area. I create a seperate branch which you can pull > > from. > > Ok, sounds good. > > > > Regarding the names, should we then have > > > > > > time64_t ktime_get_real_seconds(void); > > > time64_t ktime_get_seconds(void); > > > > I like that one. Moving all the time interfaces to a ktime_ prefix and > > let the default implementation as CLOCK_MONOTONIC and the others with > > the added '_real', '_boot' ... describe their CLOCK_WHATEVER property > > makes it pretty clear. > > Good. So you can apply this patch as-is and Heena will get you the > other one. Not so much. Applying patch timekeeping-added-a-function-to-return-tv_sec-portion-of-ktime_get_real_ts64.patch patching file include/linux/timekeeping.h Hunk #1 FAILED at 29. 1 out of 1 hunk FAILED -- rejects in file include/linux/timekeeping.h patching file kernel/time/timekeeping.c Hunk #1 FAILED at 673. 1 out of 1 hunk FAILED -- rejects in file kernel/time/timekeeping.c That one depends on the other one. So I wait for a combo of both from Heena. Thanks, tglx