From: Thomas Gleixner <tglx@linutronix.de>
To: Josh Triplett <josh@joshtriplett.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, x86@kernel.org,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 3/3] x86: Support compiling out userspace I/O (iopl and ioperm)
Date: Wed, 29 Oct 2014 22:00:54 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1410292155300.5308@nanos> (raw)
In-Reply-To: <9d77d0e4df8feb2cb55fb21689e016a3145cb7f8.1414598511.git.josh@joshtriplett.org>
On Wed, 29 Oct 2014, Josh Triplett wrote:
> v3: Eliminated several #ifdefs, and in particular almost all #ifdefs in
> .c files, by adding a macro INIT_SET_IOPL_MASK to use in place of
> the initializer for set_iopl_mask, and using __maybe_unused rather
> than wrapping function definitions in #ifdef. Rebased on v3.18-rc1.
> Recomputed bloat-o-meter.
Can you please split this patch into smaller pieces?
- Seperate the code move to header files
- Seperate the macro stuff
- Add the #ifdef CONFIG_.... changes
Thanks,
tglx
next prev parent reply other threads:[~2014-10-29 21:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 16:02 [PATCH v3 1/3] x86: process: Unify 32-bit and 64-bit copy_thread I/O bitmap handling Josh Triplett
2014-10-29 16:03 ` [PATCH v3 2/3] x86: tss: Eliminate fragile calculation of TSS segment limit Josh Triplett
2014-10-29 16:10 ` [PATCH v3 3/3] x86: Support compiling out userspace I/O (iopl and ioperm) Josh Triplett
2014-10-29 16:59 ` Kees Cook
2014-10-29 17:17 ` josh
2014-10-29 17:20 ` H. Peter Anvin
2014-10-29 17:58 ` josh
2014-10-29 21:00 ` Thomas Gleixner [this message]
2014-11-01 19:41 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1410292155300.5308@nanos \
--to=tglx@linutronix.de \
--cc=hpa@zytor.com \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®