From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759329AbaJ3LuV (ORCPT ); Thu, 30 Oct 2014 07:50:21 -0400 Received: from www.linutronix.de ([62.245.132.108]:34591 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758559AbaJ3LuT (ORCPT ); Thu, 30 Oct 2014 07:50:19 -0400 Date: Thu, 30 Oct 2014 12:50:15 +0100 (CET) From: Thomas Gleixner To: Arnd Bergmann cc: Kevin Cernekee , f.fainelli@gmail.com, jason@lakedaemon.net, ralf@linux-mips.org, lethal@linux-sh.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, mbizon@freebox.fr, jogo@openwrt.org, linux-mips@linux-mips.org Subject: Re: [PATCH V2 03/15] genirq: Generic chip: Move irq_reg_{readl,writel} accessors into generic-chip.c In-Reply-To: Message-ID: References: <1414635488-14137-1-git-send-email-cernekee@gmail.com> <1414635488-14137-4-git-send-email-cernekee@gmail.com> <6552163.gt4ABVyYlA@wuerfel> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 30 Oct 2014, Thomas Gleixner wrote: > On Thu, 30 Oct 2014, Arnd Bergmann wrote: > > On Thursday 30 October 2014 09:43:02 Thomas Gleixner wrote: > > > > diff --git a/include/linux/irq.h b/include/linux/irq.h > > > > index 03f48d9..8049e93 100644 > > > > --- a/include/linux/irq.h > > > > +++ b/include/linux/irq.h > > > > @@ -639,13 +639,6 @@ void arch_teardown_hwirq(unsigned int irq); > > > > void irq_init_desc(unsigned int irq); > > > > #endif > > > > > > > > -#ifndef irq_reg_writel > > > > -# define irq_reg_writel(val, addr) writel(val, addr) > > > > -#endif > > > > -#ifndef irq_reg_readl > > > > -# define irq_reg_readl(addr) readl(addr) > > > > -#endif > > > > - > > > > > > Brilliant patch that. > > > > > > # git grep -l irq_reg_readl drivers/irqchip/ > > > drivers/irqchip/irq-atmel-aic.c > > > drivers/irqchip/irq-atmel-aic5.c > > > drivers/irqchip/irq-sunxi-nmi.c > > > drivers/irqchip/irq-tb10x.c > > > > Patch 1/15 changes these all. I think it's still broken because patch 2/15 > > is wrong, but it's not /that/ obviously broken. > > Oops. Missed that. But looking at: drivers/irqchip/irq-sunxi-nmi.c It's using the generic chip. So while the generic chip uses the accessor function, the driver implementation which implements extra functionality will use something hardcoded. While it does not break the current setup, it's wrong nevertheless. Thanks, tglx