From: Christoph Lameter <cl@linux.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
linux-kernel@vger.kernel.org,
Gilad Ben-Yossef <gilad@benyossef.com>, Tejun Heo <tj@kernel.org>,
John Stultz <john.stultz@linaro.org>,
Mike Frysinger <vapier@gentoo.org>,
Minchan Kim <minchan.kim@gmail.com>,
Hakan Akkan <hakanakkan@gmail.com>,
Max Krasnyansky <maxk@qti.qualcomm.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Hugh Dickins <hughd@google.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [NOHZ] Remove scheduler_tick_max_deferment
Date: Sat, 1 Nov 2014 16:52:13 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.11.1411011646280.7732@gentwo.org> (raw)
In-Reply-To: <alpine.DEB.2.11.1411012003390.5308@nanos>
On Sat, 1 Nov 2014, Thomas Gleixner wrote:
> On Fri, 31 Oct 2014, Christoph Lameter wrote:
> > The reasoning behind this function is not clear to me and removal seems
>
> The comment above the function is clear enough.
I looked around into the functions called by the timer interrupt for
accounting etc. They have measures to compensate if the HZ is not
occurring for some time.
> > to have a limited impact on the system overall. Even without the
> > cap to 1 second the system will be limited by the boundaries on the period
> > of interrupts by various devices (in my case I ended up with a 4 second
> > interval on x86 because of the limitations of periodicy of the underlying
> > interupt source).
>
> And just because it happens to do so on your machine it's not
> guaranteed.
When would it not occur? Where do we lack a measure to cope with missing
timer interrupts now?
> > Moreover this artificial limits the impact the benefit that commit
> > commit 7cc36bbddde5cd0c98f0c06e3304ab833d662565 (on-demand vmstat workers)
> > should be giving us.
> >
> > Without this patch timer interrupts will still occur in 1 second intervals
> > but no vmstat kworker will run. On a processor where all other
>
> And what has this to do with vmstat kworker? Nothing.
This means that the timer interrupt occurs needlessly.
> > events have been redirected to other processors nothing will be
> > going on just timer interrupts that do not do much.
>
> What the timer interrupt does is very clearly explained in the comment
> above the function you want to remove.
Could you be specific?
> > With this patch the maximum deferrability of other items will become
> > evident and work can then proceed on eliminating those
>
> What about eliminating the requirement for this function first? It's
> clear what it does and it's also clear that this can be done remotely
> from a housekeeping cpu when the full nohz cpu is busy looping in user
> space. The function is there because nobody has tackled that problem
> yet.
Where does that requirement exist?
> You don't want to tackle the 4 seconds limit of the underlying
> hardware. What you really want is to eliminate the [hr]timer which is
> preventing the hardware timer to be shutdown completely.
Yes after the 1 second issue here has been avoided we can move on to the 4
second one and so on.
> But we care about that _after_ we solved the scheduler tick
> requirement because that is the most evident one.
Why does the scheduler require that tick? It seems that the processor is
always busy running exactly 1 process when the tick is not
occurring. Anything else will switch on the tick again. So the information
that the scheduler has never becomes outdated.
next prev parent reply other threads:[~2014-11-01 21:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 16:01 Christoph Lameter
2014-11-01 19:18 ` Thomas Gleixner
2014-11-01 21:52 ` Christoph Lameter [this message]
2014-11-01 22:33 ` Thomas Gleixner
2014-11-06 17:24 ` Christoph Lameter
2014-11-10 7:11 ` Viresh Kumar
2014-11-10 15:31 ` Paul E. McKenney
2014-11-10 16:21 ` Christoph Lameter
2014-11-10 18:26 ` Christoph Lameter
2014-11-11 17:15 ` Future of NOHZ full/isolation development (was Re: [NOHZ] Remove scheduler_tick_max_deferment) Frederic Weisbecker
2014-11-11 17:39 ` Paul E. McKenney
2014-11-11 18:00 ` Christoph Lameter
2014-11-12 6:11 ` Viresh Kumar
2014-11-12 13:54 ` Frederic Weisbecker
2014-11-12 14:56 ` Viresh Kumar
2014-11-12 15:06 ` Peter Zijlstra
2014-11-12 15:16 ` Viresh Kumar
2014-11-13 7:22 ` Viresh Kumar
2014-11-10 16:19 ` [NOHZ] Remove scheduler_tick_max_deferment Christoph Lameter
2014-11-10 22:43 ` Frederic Weisbecker
2014-11-11 14:58 ` Christoph Lameter
2014-11-11 15:36 ` Frederic Weisbecker
2014-11-11 17:08 ` Christoph Lameter
2014-11-10 20:26 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1411011646280.7732@gentwo.org \
--to=cl@linux.com \
--cc=fweisbec@gmail.com \
--cc=gilad@benyossef.com \
--cc=hakanakkan@gmail.com \
--cc=hpa@zytor.com \
--cc=hughd@google.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qti.qualcomm.com \
--cc=minchan.kim@gmail.com \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vapier@gentoo.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®