From: Thomas Gleixner <tglx@linutronix.de>
To: James Custer <jcuster@sgi.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
Russ Anderson <rja@sgi.com>
Subject: Re: [PATCH] x86: UV BAU Increase maximum CPUs per socket/hub
Date: Sat, 1 Nov 2014 21:23:47 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1411012121350.5308@nanos> (raw)
In-Reply-To: <1414792180-102802-1-git-send-email-jcuster@sgi.com>
On Fri, 31 Oct 2014, James Custer wrote:
> We have encountered hardware with 18 cores/socket that gives 36 CPUs/socket
> with hyperthreading enabled. This exceeds the current MAX_CPUS_PER_SOCKET
> causing a failure in get_cpu_topology. Increase MAX_CPUS_PER_SOCKET to 64
> and MAX_CPUS_PER_UVHUB to 128.
>
> Additionally, this exposed another bug. When get_cpu_topology fails, we
> need to make sure that we do not use bau_control->statp (e.g. when a
> user reads /proc/sgi_uv/ptc_statistics causing ptc_seq_show to be
> invoked). In uv_bau_init we call set_bau_off() when
> init_per_cpu()->get_cpu_topology() fails -- therefore, to avoid
> referencing a NULL pointer we add code that detects when the bau is off
> and print out the bau is disabled.
Can you please split this in two patches. One fixing the ptc_seq_show
bug and the other increasing the constants.
If someone looks for a fix for the ptc_seq_show wreckage he definitly
is not going to look at a patch which increases the number of cpus per
socket.
Thanks,
tglx
prev parent reply other threads:[~2014-11-01 20:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 21:49 James Custer
2014-11-01 20:23 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1411012121350.5308@nanos \
--to=tglx@linutronix.de \
--cc=hpa@zytor.com \
--cc=jcuster@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rja@sgi.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®