From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753762AbaKCUlf (ORCPT ); Mon, 3 Nov 2014 15:41:35 -0500 Received: from www.linutronix.de ([62.245.132.108]:55389 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753452AbaKCUld (ORCPT ); Mon, 3 Nov 2014 15:41:33 -0500 Date: Mon, 3 Nov 2014 21:41:30 +0100 (CET) From: Thomas Gleixner To: Andy Lutomirski cc: X86 ML , "linux-kernel@vger.kernel.org" , Josh Triplett , Ingo Molnar , Konrad Rzeszutek Wilk Subject: Re: [PATCH v2 2/3] x86_64,vsyscall: Rewrite comment and clean up headers in vsyscall code In-Reply-To: Message-ID: References: <9c448d5643d0fdb618f8cde9a54c21d2bcd486ce.1414618407.git.luto@amacapital.net> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 3 Nov 2014, Andy Lutomirski wrote: > On Mon, Nov 3, 2014 at 12:31 PM, Thomas Gleixner wrote: > > On Wed, 29 Oct 2014, Andy Lutomirski wrote: > > > >> vsyscall_64.c is just vsyscall emulation. Tidy it up accordingly. > >> > >> If my comment editing offends anyone, let me know and I can fix it. > >> > >> Reviewed-by: Josh Triplett > >> Signed-off-by: Andy Lutomirski > >> --- > >> arch/x86/kernel/vsyscall_64.c | 51 +++++++++++++++---------------------------- > >> 1 file changed, 18 insertions(+), 33 deletions(-) > >> > >> diff --git a/arch/x86/kernel/vsyscall_64.c b/arch/x86/kernel/vsyscall_64.c > >> index 2d912629c96e..ee622f8183f3 100644 > >> --- a/arch/x86/kernel/vsyscall_64.c > >> +++ b/arch/x86/kernel/vsyscall_64.c > >> @@ -1,52 +1,37 @@ > >> /* > >> - * Copyright (C) 2001 Andrea Arcangeli SuSE > >> - * Copyright 2003 Andi Kleen, SuSE Labs. > >> + * Mostly copyright (c) 2012-2014 Andy Lutomirski > > > > We usualy leave the old copyright notices around even if the code > > which is related to them has been removed more or less completely. > > > > So I change this to: > > > > /* > > * Copyright (c) 2012-2014 Andy Lutomirski > > * > > * Based on the original implementation: > > * Copyright (C) 2001 Andrea Arcangeli SuSE > > * Copyright 2003 Andi Kleen, SuSE Labs. > > > > and apply the whole lot. > > Would it make more sense to move those copyright notices to > arch/x86/vdso/vma.c? That's where most of the code ended up. That has already a notice from Andi and I cant figure out what parts of that have been written by Andrea. We'll worry about that when we remove vsyscall_64.c. Until then the git history will be our friend. Thanks, tglx