From: Thomas Gleixner <tglx@linutronix.de>
To: Borislav Petkov <bp@alien8.de>
Cc: Chris Clayton <chris2553@googlemail.com>,
LKML <linux-kernel@vger.kernel.org>,
Junjie Mao <eternal.n08@gmail.com>,
Kees Cook <keescook@chromium.org>, x86-ml <x86@kernel.org>
Subject: Re: [PATCH]: cross-compiling x86_64 kernel on i386 user-space fails
Date: Sun, 23 Nov 2014 20:27:24 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1411232020020.6439@nanos> (raw)
In-Reply-To: <20141122111444.GA12445@pd.tnic>
On Sat, 22 Nov 2014, Borislav Petkov wrote:
> On Sat, Nov 22, 2014 at 09:51:10AM +0000, Chris Clayton wrote:
> > Hi,
>
> Yeah, next time make sure you actually CC people :-)
>
> I've added them to CC now.
>
> > Commit e6023367d779060fddc9a52d1f474085b2b36298 broke building an x86_64 kernel in an i386. The change added a call to
> > objdump but neglected to cater for cross-compiling.
> >
> > The patch below fixes the problem for me. I see the commit is now in 3.14 and 3.17 -stable, so the patch needs to go
> > there too.
That's not a specific problem of building x86_64 on i386. The missing
cross compile prefix prevents any cross build of x86.
> CC: stable@vger.kernel.org
>
> in the commit message should help there.
>
>
> > CC: Junjie Mao <eternal.n08@gmail.com>
> > CC: Kees Cook <keescook@chromium.org>
> > CC: Thomas Gleixner <tglx@linutronix.de>
> > CC: Ingo Molnar <mingo@kernel.org>
> > Signed-off-by: Chris Clayton <chris2553@googlemail.com>
>
> Acked-by: Borislav Petkov <bp@suse.de>
>
> > ---
> > --- linux/arch/x86/boot/compressed/Makefile~ 2014-11-22 08:56:50.359706324 +0000
> > +++ linux/arch/x86/boot/compressed/Makefile 2014-11-22 09:04:06.615693435 +0000
> > @@ -76,7 +76,7 @@ suffix-$(CONFIG_KERNEL_XZ) := xz
> > suffix-$(CONFIG_KERNEL_LZO) := lzo
> > suffix-$(CONFIG_KERNEL_LZ4) := lz4
> >
> > -RUN_SIZE = $(shell objdump -h vmlinux | \
> > +RUN_SIZE = $(shell ${CROSS_COMPILE}objdump -h vmlinux | \
While that works, this wants to be:
+RUN_SIZE = $(shell $(OBJDUMP) -h vmlinux | \
I'll fix it up.
Thanks,
tglx
next prev parent reply other threads:[~2014-11-23 19:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-22 9:51 Chris Clayton
2014-11-22 11:14 ` Borislav Petkov
2014-11-22 16:00 ` Kees Cook
2014-11-23 19:27 ` Thomas Gleixner [this message]
2014-11-23 19:57 ` Borislav Petkov
2014-11-23 20:24 ` [tip:x86/urgent] x86: Use $(OBJDUMP) instead of plain objdump tip-bot for Chris Clayton
2014-12-01 20:48 ` Chris Clayton
2014-12-01 21:13 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1411232020020.6439@nanos \
--to=tglx@linutronix.de \
--cc=bp@alien8.de \
--cc=chris2553@googlemail.com \
--cc=eternal.n08@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®