From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755730AbbAOVbP (ORCPT ); Thu, 15 Jan 2015 16:31:15 -0500 Received: from www.linutronix.de ([62.245.132.108]:58522 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751566AbbAOVbN (ORCPT ); Thu, 15 Jan 2015 16:31:13 -0500 Date: Thu, 15 Jan 2015 22:30:50 +0100 (CET) From: Thomas Gleixner To: Jiang Liu cc: "Rafael J. Wysocki" , Bjorn Helgaas , Yinghai Lu , Borislav Petkov , Len Brown , Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [RFC Patch 16/19] ACPI: Introduce helper function acpi_dev_filter_resource_type() In-Reply-To: <1420684386-5975-17-git-send-email-jiang.liu@linux.intel.com> Message-ID: References: <1420684386-5975-1-git-send-email-jiang.liu@linux.intel.com> <1420684386-5975-17-git-send-email-jiang.liu@linux.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 8 Jan 2015, Jiang Liu wrote: > Introduce helper function acpi_dev_filter_resource_type(), which may > be used by acpi_dev_get_resources() to filer out resource based on > resource type. > > Signed-off-by: Jiang Liu > --- > drivers/acpi/resource.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++ > include/linux/acpi.h | 1 + > 2 files changed, 55 insertions(+) > > diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c > index 54204ac94f8e..8ea7c26d6915 100644 > --- a/drivers/acpi/resource.c > +++ b/drivers/acpi/resource.c > @@ -570,3 +570,57 @@ int acpi_dev_get_resources(struct acpi_device *adev, struct list_head *list, > return c.count; > } > EXPORT_SYMBOL_GPL(acpi_dev_get_resources); > + > +/** > + * acpi_dev_filter_resource_type - Filter ACPI resource according to resource > + * types > + * @ares: Input ACPI resource object. > + * @arg: Valid resource types of IORESOURCE_XXX > + * > + * This is a hepler function to support acpi_dev_get_resources(), which filters > + * ACPI resource objects according to resource types. > + */ > +int acpi_dev_filter_resource_type(struct acpi_resource *ares, void *arg) Why is the filter a void pointer instead of an simple unsigned long? That does not make any sense as you convert it to unsigned long right away: > +{ > + unsigned long type = 0, types = (unsigned long)arg; So this should be: int acpi_dev_filter_resource_type(struct acpi_resource *ares, unsigned long type_mask) or something like that. Thanks, tglx