From: Thomas Gleixner <tglx@linutronix.de>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] x86: earlyprintk cleanup
Date: Tue, 20 Jan 2015 11:29:43 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1501201103360.5526@nanos> (raw)
In-Reply-To: <1421658254-22042-1-git-send-email-kuleshovmail@gmail.com>
On Mon, 19 Jan 2015, Alexander Kuleshov wrote:
> The following two patches remove unused macro definitions from
> early_serial_console and early_printk x86 code.
Sigh. These mechanical 'follow the output of some code analyzer'
changes are really horrible.
Why not doing the obvious: Move the duplicated defines into a common
header file and be done with it?
And if you look deeper, then you'll notice that those defines are used
in two other files as well.
What's worse is that the whole set of defines is readily available in
include/uapi/linux/serial_reg.h already (just with different symbols).
So what's the point of these removal patches?
Thanks,
tglx
next prev parent reply other threads:[~2015-01-20 10:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 9:04 Alexander Kuleshov
2015-01-19 9:04 ` [PATCH 1/2] x86/early_serial_console: remove unused definitions Alexander Kuleshov
2015-01-19 9:05 ` [PATCH 2/2] x86/early_printk: " Alexander Kuleshov
2015-01-20 10:29 ` Thomas Gleixner [this message]
2015-01-20 12:37 ` [PATCH 0/2] x86: earlyprintk cleanup Alexander Kuleshov
2015-01-20 14:05 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1501201103360.5526@nanos \
--to=tglx@linutronix.de \
--cc=hpa@zytor.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®