Re: [patch 11/23] x86/x2apic: Split enable and setup function

[Thomas Gleixner <tglx@linutronix.de>]

On Fri, 16 Jan 2015, Borislav Petkov wrote:
> On Thu, Jan 15, 2015 at 09:22:26PM -0000, Thomas Gleixner wrote:
> > +/* Called from cpu_init() to enable x2apic on (secondary) cpus */
> > +void x2apic_setup(void)
> > +{
> > +	/*
> > +	 * If x2apic is not in ON state, disable it if already enabled
> > +	 * from BIOS.
> > +	 */
> > +	if (x2apic_state != X2APIC_ON) {
> > +		if (cpu_has_apic)
> 
> Let's move this test into disable_x2apic() so that callers don't have to
> pay attention.

Si, senor!
 
> >  	x86_configure_nx();
> > -	enable_x2apic();
> > +	x2apic_setup();
> 
> 64-bit only?
> 
> I'd guess so since the original call enable_x2apic() is 64-bit only too
> but why?

Don't ask me. :)